Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RuntimeError when re-ordering filters within an Alert Profiles filter group #2980

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix RuntimeError when re-ordering filters within an Alert Profiles filter group #2980

wants to merge 2 commits into from

Commits on Sep 17, 2024

  1. Add regression test for Uninett#2979

    @lunkwill42
    lunkwill42 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    12f925b View commit details
    Browse the repository at this point in the history

  2. Don't iterate over dict being modified 

    This fixes a Python 2-ism that got lost in the conversion to Python 3 a
few years back: The code would iterate over a dictionary while
potentially making modifications to it, and you cannot do that under
Python 3.

This fixes it by instead just iterating over the keys of the original
dictionary that was copied.
    @lunkwill42
    lunkwill42 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    adc86c8 View commit details
    Browse the repository at this point in the history