Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: catch exceptions #482

Merged
merged 1 commit into from
Oct 31, 2023
Merged

feat: catch exceptions #482

merged 1 commit into from
Oct 31, 2023

Conversation

sergkudinov
Copy link
Contributor

@sergkudinov sergkudinov commented Oct 26, 2023 •
edited
Loading

Which issue(s) this PR fixes

Fixes #449

Additional comments

Agreements

@sergkudinov sergkudinov mentioned this pull request Oct 26, 2023
Closed
2 tasks
PaulFarault
PaulFarault requested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@PaulFarault PaulFarault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this version is much better than the previous PR!

tdp/cli/utils.py Outdated Show resolved Hide resolved
@PaulFarault PaulFarault mentioned this pull request Oct 30, 2023
Closed
@sergkudinov sergkudinov merged commit 4b2a1f5 into master Oct 31, 2023
5 checks passed
@sergkudinov sergkudinov deleted the 449-catch-exceptions branch October 31, 2023 14:35
@PaulFarault PaulFarault mentioned this pull request Nov 15, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulFarault PaulFarault PaulFarault approved these changes

@rpignolet rpignolet rpignolet approved these changes

Assignees

@sergkudinov sergkudinov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid printing traceback on errors for all the tdp commands
3 participants
@sergkudinov @rpignolet @PaulFarault