Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: import deployment plan from a file ; rebase done #511

Merged
merged 2 commits into from
Nov 22, 2023
Merged

feat: import deployment plan from a file ; rebase done #511

merged 2 commits into from
Nov 22, 2023

Conversation

mdrutel
Copy link
Contributor

@mdrutel mdrutel commented Nov 15, 2023

Which issue(s) this PR fixes

Fixes #397

Additional comments

Agreements

@mdrutel mdrutel requested a review from PaulFarault November 15, 2023 13:35
@mdrutel mdrutel linked an issue Nov 15, 2023 that may be closed by this pull request
feat: Exporting and/or importing a plan from a file #397
Closed
PaulFarault
PaulFarault reviewed Nov 15, 2023
View reviewed changes
Copy link
Contributor

@PaulFarault PaulFarault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

tdp/cli/commands/plan/import_file.py Outdated Show resolved Hide resolved
tdp/cli/commands/plan/import_file.py Outdated Show resolved Hide resolved
PaulFarault
PaulFarault requested changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@PaulFarault PaulFarault left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that you have some tests issues.

@mdrutel
Copy link
Contributor Author

mdrutel commented Nov 15, 2023

I also added 1 comment, and fix the test :)

SteBaum
SteBaum approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@SteBaum SteBaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have looked at the code and also tested it and it works for me.

@mdrutel mdrutel merged commit abffc40 into master Nov 22, 2023
5 checks passed
@mdrutel mdrutel deleted the 397-feat-exporting-andor-importing-a-plan-from-a-file branch November 22, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteBaum SteBaum SteBaum approved these changes

@PaulFarault PaulFarault PaulFarault approved these changes

@rpignolet rpignolet rpignolet approved these changes

Assignees

@mdrutel mdrutel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Exporting and/or importing a plan from a file
4 participants
@mdrutel @rpignolet @PaulFarault @SteBaum