Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/mixer_module: remove unused param MOT_SLEW_MAX #23794

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

Igor-Misic
Copy link
Member

Parameter MOT_SLEW_MAX doesn't seems to be used anymore.

@bkueng bkueng merged commit b9942ad into main Oct 14, 2024
52 of 57 checks passed
@bkueng bkueng deleted the pr-remove_param_mot_slew_max branch October 14, 2024 08:03
@MaEtUgR
Copy link
Member

MaEtUgR commented Oct 16, 2024

Coincidence? #23798
I'm adding the functionality back since apparently some people use it or is it not desired anymore? Then I'd keep it down stream 🤔

@Igor-Misic
Copy link
Member Author

Coincidence? #23798 I'm adding the functionality back since apparently some people use it or is it not desired anymore? Then I'd keep it down stream 🤔

@MaEtUgR , it is a coincidence. I was looking for motor slew rate implementation in PX4 and this param just led me to the wrong path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants