Fix multi-instance publishing of satellite_info topic

[ThomasRigi]

Solved Problem

When debugging some GNSS issues I found that only the main instance of satellite_info topic was logged. This is annoying when you need to find out why one GNSS is degraded compared to the other one.

Solution

• Use _is_gps_main_advertised.load() the same way as sensor_gps is published

Changelog Entry

For release notes:

Feature/Bugfix Fix multi-instance publishing of satellite_info topic

Test coverage

• Unit/integration test: Nothing done
• Simulation/hardware testing logs: https://review.px4.io/:

1. Reference log with only one logged instance of satellite_info : https://logs.px4.io/plot_app?log=5ce58347-adf4-4905-88bd-aafe2a36341b

There are two gps instances as confirmed by sensor_gps, but only one satellite_info

2. Log with my fix: https://logs.px4.io/plot_app?log=e6eeb080-2be6-40e5-b2f8-b32a0e263ee9
   Now there are two instances of satellite_info that are logged correctly (satellite_info.00 and satellite_info.01), but also still a "zombie" satellite_info that contains one datapoint from what I can see...
   

[ThomasRigi]

Hi @dagar, do you know how to get rid of the "zombie" ? I guess it's some initialisation issue somewhere, but I thought I did the same as for sensor_gps where there is no zombie.

[dagar]

Hi @dagar, do you know how to get rid of the "zombie" ? I guess it's some initialisation issue somewhere, but I thought I did the same as for sensor_gps where there is no zombie.

No, but I've occasionally seen that other places as well. It's possible it might be a plotjuggler issue technically, but either way it would be nice to eliminate.