Gimbal: add angular rate test and fix deg/rad input #23476
+120
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is handy to test angular rate input, not just angles.
The command is in degrees, but the rest in radians. Also, set roll to NAN, rather than 0 when not set.
A gimbal user needs to be able to receive gimbal device messages such as GIMBAL_DEVICE_INFORMATION. Therefore, we need to forward this MAVLink instance.
julianoes
force-pushed
the
pr-gimbal-test-rates
branch
from
bb3d57e
to
bceb669
Compare
|
Probably should have merged this months ago... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test to test angular rate input, not just angles.
Also, this fixes MAVLink angular rate input which is in degrees but needs conversion to radians.
At least this second part should probably be backported to v1.15.
Also, make sure to forward gimbal traffic in SITL as it is required for proper discovery of a MAVLink gimbal.
Tested in SITL using typhoon_h480 model