Nacho/remove ros 1 support #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nachovizzo
commented
Feb 28, 2024
|
I agree. As discussed yesterday, we should tag it, remove ROS 1 support, and make a new release without having a separate repo. |
…cp into nacho/remove_ros_1_support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ROS 1 only has 1 year to EOL, it doesn't make sense to me to keep maintaining a codebase that is about to expire.
I have some changes in mind for the ROS wrapper, but I would avoid situations like #244, where I waste time backporting stuff that is about to be deprecated in a few months. Another problem is that for example #252 fails to build in ROS noetic: https://github.com/PRBonn/kiss-icp/actions/runs/7864536479/job/21456399582?pr=252
Proposal
Move the kiss-icp-ros-1 wrapper out of this repo, and leave it open for community usage, but not maintained by us anymore, I already have done this, I need to test the build and push it. I'd say we put it in https://github.com/PRBonn/kiss-icp-ros-1 or similar
Actions needed
v0.3.0would be the last one supporting ROS 1noeticcheck from PRs protection rules