Hides the discover more section for non-admin users #41474

jboland88 · 2025-01-31T17:08:48Z

Proposed changes:

This PR hides the "discover more" section on My Jetpack for non-admins. Only admin users can install and activate new Jetpack products, so this section is really only useful for admin users.

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Check out this branch using Jetpack Beta on a testing site
On My Jetpack as an admin user, confirm that you see the "discover more" section on My Jetpack of products the site does not have yet
Switch to a non-admin user and go back to My Jetpack. Confirm that the "discover more" section is no longer visible

github-actions · 2025-01-31T17:09:41Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the udpate/hide-discover-more-for-non-admins branch.

To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack udpate/hide-discover-more-for-non-admins

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-01-31T17:09:51Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
🔴 Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

🔴 Action required: Please add missing changelog entries for the following projects: projects/packages/my-jetpack

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Choose a review path based on your changes:
- A. Team Review: add the "[Status] Needs Team Review" label
  - For most changes, including minor cross-team impacts.
  - Example: Updating a team-specific component or a small change to a shared library.
- B. Crew Review: add the "[Status] Needs Review" label
  - For significant changes to core functionality.
  - Example: Major updates to a shared library or complex features.
- C. Both: Start with Team, then request Crew
  - For complex changes or when you need extra confidence.
  - Example: Refactor affecting multiple systems.
Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

github-actions · 2025-01-31T17:21:05Z

Code Coverage Summary

Cannot generate coverage summary while tests are failing. 🤐

Please fix the tests, or re-run the Code coverage job if it was something being flaky.

Full summary · PHP report · JS report

CodeyGuyDylan

The change works well, only requesting changes because of a type change that I believe is incorrect

CodeyGuyDylan · 2025-01-31T19:23:02Z

projects/packages/my-jetpack/global.d.ts

@@ -455,7 +455,7 @@ interface Window {
 		isAtomic: boolean;
 		sandboxedDomain: string;
 		isDevVersion: boolean;
-		userIsAdmin: string;
+		userIsAdmin: boolean;


This is actually a string

We could possibly change that if we wanted to 🤔 I do like booleans better for this sort of thing but currently it is a string 😄

ah, yep thanks - will put that back :)

… cap (#41444)

#41445) * Dont show stats module on my Jetpack if user does not have permissions to see it * a few small updates to stats permission check

CodeyGuyDylan

LGTM!

IanRamosC

LGTM!

…r-more-for-non-admins

jboland88 added 4 commits January 29, 2025 10:49

allows My Jetpack product endpoints to return for non-admin users

2bd294e

changelog

915af30

Merge branch 'trunk' into fix/my-jetpack-for-non-admins

3cc2c8b

Merge branch 'trunk' into fix/my-jetpack-for-non-admins

47958b3

github-actions bot added [Package] My Jetpack [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jan 31, 2025

CodeyGuyDylan requested changes Jan 31, 2025

View reviewed changes

CodeyGuyDylan reviewed Jan 31, 2025

View reviewed changes

jboland88 added 4 commits January 31, 2025 16:53

bails during red bubble load if the user does not have manage_options…

c8023b1

… cap (#41444)

Dont show stats module on my Jetpack if user does not have permissions (

2f12118

#41445) * Dont show stats module on my Jetpack if user does not have permissions to see it * a few small updates to stats permission check

fix conflicts

b47657e

Correct a typing change

494c17e

jboland88 force-pushed the udpate/hide-discover-more-for-non-admins branch from 0060d83 to 494c17e Compare January 31, 2025 22:28

CodeyGuyDylan approved these changes Jan 31, 2025

View reviewed changes

IanRamosC approved these changes Jan 31, 2025

View reviewed changes

jboland88 force-pushed the fix/my-jetpack-for-non-admins branch from 2f12118 to 4cc6acc Compare February 3, 2025 22:06

Merge branch 'fix/my-jetpack-for-non-admins' into udpate/hide-discove…

74c4cc9

…r-more-for-non-admins

jboland88 merged commit 242b6a8 into fix/my-jetpack-for-non-admins Feb 4, 2025
12 of 14 checks passed

jboland88 deleted the udpate/hide-discover-more-for-non-admins branch February 4, 2025 22:42

github-actions bot removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Feb 4, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hides the discover more section for non-admin users #41474

Hides the discover more section for non-admin users #41474

jboland88 commented Jan 31, 2025

github-actions bot commented Jan 31, 2025 •

edited

Loading

github-actions bot commented Jan 31, 2025

github-actions bot commented Jan 31, 2025 •

edited

Loading

CodeyGuyDylan left a comment

CodeyGuyDylan Jan 31, 2025

jboland88 Jan 31, 2025

CodeyGuyDylan left a comment

IanRamosC left a comment

Hides the discover more section for non-admin users #41474

Hides the discover more section for non-admin users #41474

Conversation

jboland88 commented Jan 31, 2025

Proposed changes:

Does this pull request change what data or activity we track or use?

Testing instructions:

github-actions bot commented Jan 31, 2025 • edited Loading

github-actions bot commented Jan 31, 2025

github-actions bot commented Jan 31, 2025 • edited Loading

Code Coverage Summary

CodeyGuyDylan left a comment

Choose a reason for hiding this comment

CodeyGuyDylan Jan 31, 2025

Choose a reason for hiding this comment

jboland88 Jan 31, 2025

Choose a reason for hiding this comment

CodeyGuyDylan left a comment

Choose a reason for hiding this comment

IanRamosC left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 31, 2025 •

edited

Loading

github-actions bot commented Jan 31, 2025 •

edited

Loading