Dont show stats module on my Jetpack if user does not have permissions (

#41445) * Dont show stats module on my Jetpack if user does not have permissions to see it * a few small updates to stats permission check
Automattic · Jan 31, 2025 · 2f12118 · 2f12118
1 parent c8023b1
commit 2f12118
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/projects/packages/my-jetpack/_inc/components/product-cards-section/index.tsx b/projects/packages/my-jetpack/_inc/components/product-cards-section/index.tsx
@@ -109,6 +109,8 @@ const ProductCardsSection: FC< ProductCardsSectionProps > = ( { noticeMessage }
 		data: { ownedProducts, unownedProducts },
 	} = useProductsByOwnership();
 
+	const { canUserViewStats } = getMyJetpackWindowInitialState();
+
 	const unownedSectionTitle = useMemo( () => {
 		return ownedProducts.length > 0
 			? __( 'Discover more', 'jetpack-my-jetpack' )
@@ -117,11 +119,12 @@ const ProductCardsSection: FC< ProductCardsSectionProps > = ( { noticeMessage }
 
 	const filterProducts = ( products: JetpackModule[] ) => {
 		const productsWithNoCard = [ 'scan', 'security', 'growth', 'extras', 'complete' ];
+		// If the user cannot view stats, filter out the stats card
+		if ( ! canUserViewStats ) {
+			productsWithNoCard.push( 'stats' );
+		}
 		return products.filter( product => {
-			if ( productsWithNoCard.includes( product ) ) {
-				return false;
-			}
-			return true;
+			return ! productsWithNoCard.includes( product );
 		} );
 	};
 

diff --git a/projects/packages/my-jetpack/global.d.ts b/projects/packages/my-jetpack/global.d.ts
@@ -120,6 +120,7 @@ interface Window {
 		blogID: string;
 		fileSystemWriteAccess: 'yes' | 'no';
 		isStatsModuleActive: string;
+		canUserViewStats: boolean;
 		isUserFromKnownHost: string;
 		jetpackManage: {
 			isAgencyAccount: boolean;

diff --git a/projects/packages/my-jetpack/src/class-initializer.php b/projects/packages/my-jetpack/src/class-initializer.php
@@ -297,6 +297,7 @@ public static function enqueue_scripts() {
 					'dismissed'  => \Jetpack_Options::get_option( 'dismissed_recommendations', false ),
 				),
 				'isStatsModuleActive'    => $modules->is_active( 'stats' ),
+				'canUserViewStats'       => current_user_can( 'manage_options' ) || current_user_can( 'view_stats' ),
 				'isUserFromKnownHost'    => self::is_user_from_known_host(),
 				'isCommercial'           => self::is_commercial_site(),
 				'sandboxedDomain'        => $sandboxed_domain,