Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hides the discover more section for non-admin users #41474

Merged
merged 9 commits into from
Feb 4, 2025
+3 −3
Merged

Hides the discover more section for non-admin users #41474

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2bd294e
allows My Jetpack product endpoints to return for non-admin users
jboland88 Jan 29, 2025
915af30
changelog
jboland88 Jan 29, 2025
3cc2c8b
Merge branch 'trunk' into fix/my-jetpack-for-non-admins
jboland88 Jan 30, 2025
47958b3
Merge branch 'trunk' into fix/my-jetpack-for-non-admins
jboland88 Jan 30, 2025
c8023b1
bails during red bubble load if the user does not have manage_options…
jboland88 Jan 31, 2025
2f12118
Dont show stats module on my Jetpack if user does not have permission…
jboland88 Jan 31, 2025
b47657e
fix conflicts
jboland88 Jan 31, 2025
494c17e
Correct a typing change
jboland88 Jan 31, 2025
74c4cc9
Merge branch 'fix/my-jetpack-for-non-admins' into udpate/hide-discove…
jboland88 Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions projects/packages/my-jetpack/_inc/components/product-cards-section/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,8 @@
data: { ownedProducts, unownedProducts },
} = useProductsByOwnership();

const { canUserViewStats } = getMyJetpackWindowInitialState();

const { canUserViewStats, userIsAdmin } = getMyJetpackWindowInitialState();

Check failure on line 113 in projects/packages/my-jetpack/_inc/components/product-cards-section/index.tsx

View workflow job for this annotation

GitHub Actions / ESLint (non-excluded files only) 

Delete `··`
const unownedSectionTitle = useMemo( () => {
return ownedProducts.length > 0
? __( 'Discover more', 'jetpack-my-jetpack' )
Expand Down Expand Up @@ -147,7 +147,7 @@
</AdminSectionHero>
) }

{ filteredUnownedProducts.length > 0 && (
{ userIsAdmin && filteredUnownedProducts.length > 0 && (
<Container horizontalSpacing={ 6 } horizontalGap={ noticeMessage ? 3 : 6 }>
<Col>
<Col sm={ 4 } md={ 8 } lg={ 12 } className={ styles.cardListTitle }>
Expand Down
Loading