Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Article spider template #91

Merged
merged 26 commits into from
Dec 16, 2024
Merged

Article spider template #91

merged 26 commits into from
Dec 16, 2024

Conversation

PyExplorer
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 90.91904% with 83 lines in your changes missing coverage. Please review.

Project coverage is 95.39%. Comparing base (552223e) to head (bacdae4).

Files with missing lines Patch % Lines
zyte_spider_templates/_addon.py 71.60% 23 Missing ⚠️
zyte_spider_templates/spiders/article.py 85.62% 23 Missing ⚠️
zyte_spider_templates/middlewares.py 92.74% 19 Missing ⚠️
zyte_spider_templates/_incremental/manager.py 90.14% 14 Missing ⚠️
zyte_spider_templates/pages/article_heuristics.py 97.11% 3 Missing ⚠️
zyte_spider_templates/_incremental/middleware.py 96.96% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
- Coverage   97.99%   95.39%   -2.61%     
==========================================
  Files          19       25       +6     
  Lines        1547     2454     +907     
==========================================
+ Hits         1516     2341     +825     
- Misses         31      113      +82     
Files with missing lines Coverage Δ
zyte_spider_templates/__init__.py 100.00% <100.00%> (ø)
zyte_spider_templates/feeds.py 100.00% <100.00%> (ø)
zyte_spider_templates/heuristics.py 100.00% <100.00%> (ø)
zyte_spider_templates/pages/__init__.py 100.00% <100.00%> (ø)
zyte_spider_templates/params.py 96.32% <100.00%> (+0.05%) ⬆️
zyte_spider_templates/utils.py 100.00% <100.00%> (ø)
zyte_spider_templates/_incremental/middleware.py 96.96% <96.96%> (ø)
zyte_spider_templates/pages/article_heuristics.py 97.11% <97.11%> (ø)
zyte_spider_templates/_incremental/manager.py 90.14% <90.14%> (ø)
zyte_spider_templates/middlewares.py 92.40% <92.74%> (+2.40%) ⬆️
... and 2 more

docs/reference/api.rst Outdated Show resolved Hide resolved
PyExplorer and others added 23 commits December 6, 2024 22:18
Only enable DropLowProbabilityItemPipeline for the articles spider.
It should work fine, but we have less experience running it in
production, as compared to e-commerce template.
# Conflicts:
#	zyte_spider_templates/__init__.py
@kmike kmike merged commit 262e603 into main Dec 16, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants