Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job postings + ProductList extraction #92

Merged
merged 25 commits into from
Dec 16, 2024

Conversation

wRAR
Copy link
Member

@wRAR wRAR commented Dec 6, 2024

#82 + #90, on top of #91

@wRAR wRAR changed the base branch from main to articles_to_main December 6, 2024 13:42
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 93.85475% with 11 lines in your changes missing coverage. Please review.

Project coverage is 95.36%. Comparing base (bacdae4) to head (f35a621).
Report is 26 commits behind head on articles_to_main.

Files with missing lines Patch % Lines
zyte_spider_templates/spiders/ecommerce.py 89.65% 6 Missing ⚠️
zyte_spider_templates/spiders/job_posting.py 95.69% 4 Missing ⚠️
zyte_spider_templates/spiders/base.py 93.33% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           articles_to_main      #92      +/-   ##
====================================================
- Coverage             95.39%   95.36%   -0.04%     
====================================================
  Files                    25       26       +1     
  Lines                  2454     2609     +155     
====================================================
+ Hits                   2341     2488     +147     
- Misses                  113      121       +8     
Files with missing lines Coverage Δ
zyte_spider_templates/__init__.py 100.00% <100.00%> (ø)
zyte_spider_templates/spiders/article.py 85.88% <100.00%> (+0.26%) ⬆️
zyte_spider_templates/spiders/serp.py 93.80% <100.00%> (+0.16%) ⬆️
zyte_spider_templates/spiders/base.py 86.20% <93.33%> (+2.48%) ⬆️
zyte_spider_templates/spiders/job_posting.py 95.69% <95.69%> (ø)
zyte_spider_templates/spiders/ecommerce.py 94.88% <89.65%> (-2.18%) ⬇️

... and 1 file with indirect coverage changes

Gallaecio and others added 8 commits December 12, 2024 14:21
Extend the Search Queries description
It is useful as-is, but there are known issues - e.g. JS pagination
is common on job websites, and it's not handled by the spider, so on
many websites it can only extract jobs from the first page.
@kmike kmike merged commit 8e040fa into articles_to_main Dec 16, 2024
10 of 11 checks passed
@wRAR wRAR deleted the job-posting-product-list branch December 18, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants