channels: Add filter search box to Subscribed Channels page #2092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements issue zulip#2078, a follow-up to zulip#1406. The Figma design for the Subscribed Channels page includes a 'Filter channels' search box at the top. This feature allows users to quickly find channels by typing a search query. The search filtering is: - Real-time (updates as the user types) - Case-insensitive - Partial match (searches within channel names) - Works for both pinned and unpinned channels The implementation includes: - TextField widget with search icon at the top of the channels list - TextEditingController and state management for search query - Filtering logic in _filterSubscription helper method - Styling that matches the Figma design specifications - New localization string 'channelsPageFilterPlaceholder' - Proper handling of empty search results (doesn't show the 'not subscribed' placeholder when filter returns no matches) - 8 new comprehensive test cases covering various filter scenarios All existing tests continue to pass (28/28 tests passing). Fixes: zulip#2078
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements issue #2078, a follow-up to #1406.
The Figma design for the Subscribed Channels page includes a 'Filter channels' search box at the top. This feature allows users to quickly find channels by typing a search query.
The search filtering is:
The implementation includes:
All existing tests continue to pass (28/28 tests passing).
WhatsApp.Video.2026-01-23.at.3.01.59.PM.mp4
Fixes: #2078