dms: Add filter search box to Direct Messages page #2094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements the 'Filter direct messages' search box feature on the Direct Messages tab, matching the Figma design. The search filtering is: * Real-time (updates as the user types) * Case-insensitive * Filters by recipient names (User display names) * Works for 1:1, Group, and Self DMs The implementation includes: * '_FilterDmsSearchBox' widget in 'RecentDmConversationsPageBody' * 'TextEditingController' state and filter logic * 'CustomScrollView' adoption to support scrolling search box and list * New localization string 'recentDmConversationsFilterPlaceholder' * Comprehensive tests covering all filter scenarios and empty states All existing tests continue to pass (34/34 passing). Fixes: zulip#1903
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the 'Filter direct messages' search box feature on the Direct Messages tab, matching the Figma design.
The search filtering is:
The implementation includes:
All existing tests continue to pass (34/34 passing).
WhatsApp.Video.2026-01-23.at.4.19.07.PM.mp4
Fixes: #1903