Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Fixes #280 by allowing null ResourceEvent #281

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jguittard
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 51.143% when pulling a63fafc on jguittard:feature/resource-event into 61ee32e on zfcampus:develop.

@jguittard
Copy link
Contributor Author

@webimpress would you mind having a look and give me your feedbacks about that?

@michalbundyra
Copy link
Member

@jguittard I have a couple concerns about this PR:

Note that when using default arguments, any defaults should be on the right side of any non-default arguments

I've checked many Zend and Apigility packages and I haven't found any default values on left side.

  • it causes Strict Standard error on PHP 5.6 and Warning on PHP 7.0+ (it seems to be not a BC Break (?), but to avoid this error/warning folks have to update theirs code - if they overriding these methods or implements interface QueryCreateFilterInterface)
  • not entirely sure if this is needed - please see my ResourceEvent should be optional in query filters and providers #280 (comment)
  • if yes then would be nice to have some tests
  • ... and need to be changed everywhere - for example also in: ZFTestApigilityDb\Query\CreateFilter\ArtistCreateFilter

@michalbundyra
Copy link
Member

Ping @jguittard

@michalbundyra
Copy link
Member

As I noted in #280 (comment) this is also BC Break. I think we should try to find another solution to avoid BC Break.

@weierophinney
Copy link
Member

This repository has been closed and moved to laminas-api-tools/api-tools-doctrine; a new issue has been opened at laminas-api-tools/api-tools-doctrine#6.

@weierophinney
Copy link
Member

This repository has been moved to laminas-api-tools/api-tools-doctrine. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone laminas-api-tools/api-tools-doctrine to another directory.
  • Copy the files from the second bullet point to the clone of laminas-api-tools/api-tools-doctrine.
  • In your clone of laminas-api-tools/api-tools-doctrine, commit the files, push to your fork, and open the new PR.
    We will be providing tooling via laminas/laminas-migration soon to help automate the process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants