-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #280 by allowing null ResourceEvent #6
Comments
Coverage remained the same at 51.143% when pulling a63fafc6ebbd06fda5d35e1b8a0e04d2daa4be4a on jguittard:feature/resource-event into 61ee32e on zfcampus:develop. Originally posted by @coveralls at zfcampus/zf-apigility-doctrine#281 (comment) |
@webimpress would you mind having a look and give me your feedbacks about that? Originally posted by @jguittard at zfcampus/zf-apigility-doctrine#281 (comment) |
@jguittard I have a couple concerns about this PR:
I've checked many Zend and Apigility packages and I haven't found any default values on left side.
Originally posted by @michalbundyra at zfcampus/zf-apigility-doctrine#281 (comment) |
Ping @jguittard Originally posted by @michalbundyra at zfcampus/zf-apigility-doctrine#281 (comment) |
As I noted in zfcampus/zf-apigility-doctrine#280 (comment) this is also BC Break. I think we should try to find another solution to avoid BC Break. Originally posted by @michalbundyra at zfcampus/zf-apigility-doctrine#281 (comment) |
Originally posted by @jguittard at zfcampus/zf-apigility-doctrine#281
The text was updated successfully, but these errors were encountered: