Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #280 by allowing null ResourceEvent #6

Open
weierophinney opened this issue Dec 31, 2019 · 5 comments
Open

Fixes #280 by allowing null ResourceEvent #6

weierophinney opened this issue Dec 31, 2019 · 5 comments

Comments

@weierophinney
Copy link
Contributor


Originally posted by @jguittard at zfcampus/zf-apigility-doctrine#281

@weierophinney
Copy link
Contributor Author

Coverage Status

Coverage remained the same at 51.143% when pulling a63fafc6ebbd06fda5d35e1b8a0e04d2daa4be4a on jguittard:feature/resource-event into 61ee32e on zfcampus:develop.


Originally posted by @coveralls at zfcampus/zf-apigility-doctrine#281 (comment)

@weierophinney
Copy link
Contributor Author

@webimpress would you mind having a look and give me your feedbacks about that?


Originally posted by @jguittard at zfcampus/zf-apigility-doctrine#281 (comment)

@weierophinney
Copy link
Contributor Author

@jguittard I have a couple concerns about this PR:

Note that when using default arguments, any defaults should be on the right side of any non-default arguments

I've checked many Zend and Apigility packages and I haven't found any default values on left side.

  • it causes Strict Standard error on PHP 5.6 and Warning on PHP 7.0+ (it seems to be not a BC Break (?), but to avoid this error/warning folks have to update theirs code - if they overriding these methods or implements interface QueryCreateFilterInterface)
  • not entirely sure if this is needed - please see my ResourceEvent should be optional in query filters and providers zfcampus/zf-apigility-doctrine#280 (comment)
  • if yes then would be nice to have some tests
  • ... and need to be changed everywhere - for example also in: ZFTestApigilityDb\Query\CreateFilter\ArtistCreateFilter

Originally posted by @michalbundyra at zfcampus/zf-apigility-doctrine#281 (comment)

@weierophinney
Copy link
Contributor Author

Ping @jguittard


Originally posted by @michalbundyra at zfcampus/zf-apigility-doctrine#281 (comment)

@weierophinney
Copy link
Contributor Author

As I noted in zfcampus/zf-apigility-doctrine#280 (comment) this is also BC Break. I think we should try to find another solution to avoid BC Break.


Originally posted by @michalbundyra at zfcampus/zf-apigility-doctrine#281 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant