VOC-406 Introduces LocalesWithText as a way to abstract away from Map<String,String> #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ling with Map<String, String>. Allows us to move away from a Util and use methods and extensions instead. Organizes a few util package files into locale package
IanCrossCD
requested review from
nicholas-cook,
jrtb,
stechkev,
nerdsosky,
jollygreenegiant,
willdenne,
caroline-wang-320 and
PaulKlauser
as code owners
|
I want to move away from using LocaleString all together but Locale was not friendly to conversions in my 10 minute attempt. I could at least strip it from Domain and below if our models had separation :) |
PaulKlauser
reviewed
Nov 15, 2023
| } | ||
|
|
||
| } | ||
| } |
There was a problem hiding this comment.
Dang, Moshi doesn't play nice with typealiases out of the box?
PaulKlauser
reviewed
Nov 15, 2023
| /** | ||
| * Sets the string corresponding to the given localeString. | ||
| * @param localeString | ||
| * @param text |
There was a problem hiding this comment.
Is there value in including @param tags that have no further description?
PaulKlauser
approved these changes
Nov 15, 2023
…lias in DB converters
…hub.com/willowtreeapps/vocable-android into VOC-406/make-localized-types-more-clear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Introduces LocalesWithText as a way to abstract away from Map<String,String>.
Allows us to move away from a Util and use methods and extensions instead.
Organizes a few util package files into locale package.
No new DB manipulation should be necessary since its transformed from a string in both scenarios.
Acceptance Criteria satisfied
Regression Testing