Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make localized types more clear #406

Closed
PaulKlauser opened this issue Aug 28, 2023 · 0 comments · Fixed by #440
Closed

Make localized types more clear #406

PaulKlauser opened this issue Aug 28, 2023 · 0 comments · Fixed by #440
Assignees
@IanCrossCD
Labels
tech debt

Comments

@PaulKlauser
Copy link
Collaborator

PaulKlauser commented Aug 28, 2023 •
edited
Loading

Currently there are several generic Maps and Pairs on <String, String>, which makes it challenging to reason about what the localization code is actually doing. Create custom types with clear names to make these operations more clear.

This is seen in LocaleUtils and its call sites primarily.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IanCrossCD IanCrossCD

Labels
tech debt
Projects
Vocable-Android
Status: Done
Milestone
No milestone
2 participants
@PaulKlauser @IanCrossCD