Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Ruby 2.7 support, and take advantage of Ruby 3.0 #485

Merged
merged 4 commits into from
Apr 15, 2024

Conversation

faisal
Copy link
Contributor

@faisal faisal commented Apr 2, 2024

Drop support for Ruby 2.7.

  • In the gemspec, Bump spec.required_ruby_version to 3.0, and bump
    some of the gem requirements that were held back by the need for
    Ruby 2.7 compatibility.
  • Bump rubocop's TargetRubyVersion to 3.0. Take safe autocorrections.
  • Remove Ruby 2.7 from the ruby-version lists in the test matrix.

Note: This is one commit on top of the pull request for updating dependencies that still work on Ruby 2.7. I split them this way on the theory that a Rubycritic 4.9.1 could keep Ruby 2.7 support, then a Rubycritic 5.0 could bump the minimum support bar to Ruby 3.0 (which is expected to EOL two days ago). I think it approach gives flexibility while settling on a compatibility policy, but they could also be squashed together.

Check list:

@faisal faisal changed the title Drop Ruby 2.7 support Drop Ruby 2.7 support, and take advantage of Ruby 2.0 Apr 2, 2024
@faisal faisal changed the title Drop Ruby 2.7 support, and take advantage of Ruby 2.0 Drop Ruby 2.7 support, and take advantage of Ruby 3.0 Apr 2, 2024
@faisal faisal force-pushed the ruby_3 branch 2 times, most recently from 43ea5f0 to c25ad90 Compare April 11, 2024 00:05
@nunosilva800
Copy link
Collaborator

I split them this way on the theory that a Rubycritic 4.9.1 could keep Ruby 2.7 support,

yeah, lets merge #480 first, then rebase this.

@nunosilva800
Copy link
Collaborator

@faisal #487

…_parser dependencies

Also address Lint/UselessAssignment and Style/MapIntoArray warnings that newer versions of rubocop will complain about on newer versions of Ruby.

prep for ruby 3
CHANGELOG.md Outdated Show resolved Hide resolved
@nunosilva800 nunosilva800 merged commit 034d612 into whitesmith:main Apr 15, 2024
22 checks passed
@faisal faisal deleted the ruby_3 branch April 15, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants