Update CI workflow file to check with Ruby 3.3 #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Ruby 3.3 to the test matrix. - Run the MarkdownLint task using Ruby 3.3.
faisal
added a commit
to faisal/rubycritic
that referenced
this pull request
Apr 15, 2024
- Drop support for Ruby 3.0. - Update Rubycritic config to target Ruby 3.1. Apply all safe autocorrections except for Style/HashSyntax. - Set Rubycritic's Style/HashSyntax EnforcedShorthandSyntax to 'never', which keeps the old style in place (and consistent) until we decide to convert. - Add Ruby 3.3 to the test matrix and Drop Ruby 3.0 (which largely includes the changes in whitesmith#488, so we'll need to rebase if that's landed when we do something with this)
faisal
added a commit
to faisal/rubycritic
that referenced
this pull request
Apr 16, 2024
- Drop support for Ruby 3.0. - Update Rubycritic config to target Ruby 3.1. Apply all safe autocorrections except for Style/HashSyntax. - Set Rubycritic's Style/HashSyntax EnforcedShorthandSyntax to 'never', which keeps the old style in place (and consistent) until we decide to convert. - Add Ruby 3.3 to the test matrix and Drop Ruby 3.0 (which largely includes the changes in whitesmith#488, so we'll need to rebase if that's landed when we do something with this)
faisal
added a commit
to faisal/rubycritic
that referenced
this pull request
May 24, 2024
- Drop support for Ruby 3.0. - Update Rubycritic config to target Ruby 3.1. Apply all safe autocorrections except for Style/HashSyntax. - Set Rubycritic's Style/HashSyntax EnforcedShorthandSyntax to 'never', which keeps the old style in place (and consistent) until we decide to convert. - Add Ruby 3.3 to the test matrix and Drop Ruby 3.0 (which largely includes the changes in whitesmith#488, so we'll need to rebase if that's landed when we do something with this) Bump minitest, mocha, rubocop dependencies
faisal
added a commit
to faisal/rubycritic
that referenced
this pull request
May 24, 2024
- Drop support for Ruby 3.0. - Update Rubycritic config to target Ruby 3.1. Apply all safe autocorrections except for Style/HashSyntax. - Set Rubycritic's Style/HashSyntax EnforcedShorthandSyntax to 'never', which keeps the old style in place (and consistent) until we decide to convert. - Add Ruby 3.3 to the test matrix and Drop Ruby 3.0 (which largely includes the changes in whitesmith#488, so we'll need to rebase if that's landed when we do something with this)
faisal
added a commit
to faisal/rubycritic
that referenced
this pull request
Jun 7, 2024
- Drop support for Ruby 3.0. - Update Rubycritic config to target Ruby 3.1. Apply all safe autocorrections except for Style/HashSyntax. - Set Rubycritic's Style/HashSyntax EnforcedShorthandSyntax to 'never', which keeps the old style in place (and consistent) until we decide to convert. - Add Ruby 3.3 to the test matrix and Drop Ruby 3.0 (which largely includes the changes in whitesmith#488, so we'll need to rebase if that's landed when we do something with this) - Bump minitest, mocha, rubocop dependencies
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#485 dropped support for Ruby 2.7 but didn't update the workflow file to check on Ruby 3.3. This PR fixes that omission:
Since this is only a change to the workflow file I do not believe it bears a change to
CHANGELOG.md, so I have removed that item from the check list.Check list: