cache global store get requests #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanbowensg
force-pushed
the
bowen/get-cache-request
branch
from
106b05f to
c52b927
Compare
MrWindlike
reviewed
Jan 26, 2024
src/global-store.ts
Outdated
| const cacheRequestIndex = this.requestsCache.findIndex(f => { | ||
| return f.promise === promise; | ||
| }); | ||
| this.requestsCache.splice(cacheRequestIndex, 1); |
There was a problem hiding this comment.
应该 cacheRequestIndex 不为 -1 再执行，onResponse 应该会被多次调用的，防止意外移除其他的。或者放到下面 then 那里处理也可以？
src/global-store.ts
Outdated
| .then(stop => { | ||
| this.stopWatchHandlers.set(resource, stop); | ||
| }) | ||
| .catch(e => reject(e)); |
There was a problem hiding this comment.
catch 这里应该也要移除 requestsCache
tanbowensg
force-pushed
the
bowen/get-cache-request
branch
from
c52b927 to
280092b
Compare
MrWindlike
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在应用启动时，有可能短时间内多次调用global-store的get方法。此时，第一个请求都尚未返回，所以没有缓存，因此就会连续发送多个请求。
这个pr的作用就是缓存get产生的promise。当没有data的缓存，并且请求参数和之前完全相同的话，就返回缓存的promise，而不重复发送请求。