Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous PR #34, we added a synchronization lock to
globalStore.get()
to ensure that only one valid http(s) and wbsocket(s) request is sent for the same resource concurrently, but the lock is not sufficiently restrictive: the lock is only added if the request parameters are identical, for the following reason:This PR also adds the cancelquery logic that was missing: when the websocket readyState is CONNECTING, the connection should also be closed.