Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path shape #1799

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Add path shape #1799

merged 3 commits into from
Sep 24, 2024

Conversation

jamesnw
Copy link
Collaborator

@jamesnw jamesnw commented Sep 18, 2024

Split from #1649. BCD data needs investigation- see #1649 (comment)

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Sep 18, 2024
@jamesnw jamesnw mentioned this pull request Sep 18, 2024
9 tasks
@jamesnw
Copy link
Collaborator Author

jamesnw commented Sep 18, 2024

@ddbeck Can you take a look at the BCD data?

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've filed mdn/browser-compat-data#24502 and made some minor suggestions to the name and description.

The BCD PR won't change the top-level status here—we're still checking the contexts where you can use it—but the per-key statuses will become different when BCD releases those changes.

@@ -0,0 +1,10 @@
name: "`path()` shape"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are plaintext, so you'll get literal backticks. I kinda wonder if this can't be very short though. What do you think?

Suggested change
name: "`path()` shape"
name: path()

features/path-shape.yml Outdated Show resolved Hide resolved
@ddbeck ddbeck removed their assignment Sep 24, 2024
@jamesnw jamesnw marked this pull request as ready for review September 24, 2024 15:27
@jamesnw jamesnw requested a review from ddbeck September 24, 2024 15:28
@ddbeck ddbeck merged commit 2470363 into web-platform-dx:main Sep 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants