Add clipping, shapes and masking #1649
Conversation
github-actions
bot
added
the
feature definition
groups/clipping-shapes-masking.yml
Outdated
| @@ -0,0 +1,2 @@ | |||
| name: Clipping, shapes and masking | |||
| parent: css | |||
There was a problem hiding this comment.
The potential issue with this group is that it now contains features that apply to both CSS and SVG.
Your features make sense to me, and I'm fine with making them apply to both languages, if others are. But in that case, we need to make this group belong to both CSS and SVG (which is not possible today).
There was a problem hiding this comment.
Good point- I've been thinking we will need to address the overlap between CSS and SVG more thoroughly at some point. Allowing for multiple parents for a group would be complex, so I'll remove the parent group here for now.
features/path-shape.yml.dist
Outdated
There was a problem hiding this comment.
This is a bit of a surprising result- these features do have some implementation, and I'm not sure if I'm misreading the BCD data, or if there is a bug in generating this.
features/clip-path-animatable.yml
Outdated
| @@ -0,0 +1,6 @@ | |||
| name: Animatable clipping paths | |||
| description: Clipping paths in CSS are animated using transitions and CSS animations. | |||
There was a problem hiding this comment.
| description: Clipping paths in CSS are animated using transitions and CSS animations. | |
| description: Clipping paths in CSS are animated using CSS transitions and animations. |
| @@ -0,0 +1,6 @@ | |||
| name: Animatable clipping paths | |||
| description: Clipping paths in CSS are animated using transitions and CSS animations. | |||
| spec: https://drafts.fxtf.org/css-masking-1/#the-clip-path | |||
There was a problem hiding this comment.
The 'current' spec:
| spec: https://drafts.fxtf.org/css-masking-1/#the-clip-path | |
| spec: https://www.w3.org/TR/css-masking/#the-clip-path |
I would update the other spec links to match.
There was a problem hiding this comment.
I'll defer this until resolution of #1785
features/clip-path-boxes.yml
Outdated
| @@ -0,0 +1,8 @@ | |||
| name: Clip path boxes | |||
| description: The `fill-box`, `stroke-box`, and `view-box` values for the `clip-path` set the part of the shape that will be used to clip the element. | |||
There was a problem hiding this comment.
| description: The `fill-box`, `stroke-box`, and `view-box` values for the `clip-path` set the part of the shape that will be used to clip the element. | |
| description: The `fill-box`, `stroke-box`, and `view-box` values for `clip-path` set an edge of the elements box to use as the clipping shape. |
There was a problem hiding this comment.
I added an apostrophe in element's but wanted to verify that was the intent.
There was a problem hiding this comment.
the intent was possessive, but I'm dyslexic. The element has a box. :)
There was a problem hiding this comment.
I just wanted to confirm it wasn't like attorneys general or something 😆
features/path-shape.yml
Outdated
| @@ -0,0 +1,10 @@ | |||
| name: "`path()` shape" | |||
There was a problem hiding this comment.
Let's do this feature in a separate PR (from synchronous discussion)
There was a problem hiding this comment.
To elaborate here: the BCD data is very messy. It has subfeatures to describe support in d, shape-outside, and offset-path, but also represents that information as partial support on path. It ought to do one or the other. We'll need to fix this in BCD.
(Please @ me on that PR, when you open it.)
features/path-shape.yml
Outdated
| @@ -0,0 +1,10 @@ | |||
| name: "`path()` shape" | |||
There was a problem hiding this comment.
To elaborate here: the BCD data is very messy. It has subfeatures to describe support in d, shape-outside, and offset-path, but also represents that information as partial support on path. It ought to do one or the other. We'll need to fix this in BCD.
(Please @ me on that PR, when you open it.)
…anch 'main' of github.com:web-platform-dx/web-features into masking
Co-authored-by: Daniel D. Beck <[email protected]>
Targeting the CSS4 "Clipping, shapes & masking" group.