Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-service): initialize scope with null prototype object #4855

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

KazariEX
Copy link
Collaborator

Prevent mistakenly identifying properties such as toString inherited from Object as props.

@KazariEX KazariEX changed the title fix: initialize scope with null prototype object fix(language-service): initialize scope with null prototype object Sep 18, 2024
@KazariEX KazariEX enabled auto-merge (squash) September 18, 2024 09:42
Copy link

pkg-pr-new bot commented Sep 18, 2024

Open in Stackblitz

vue-component-meta

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-meta@4855

vue-component-type-helpers

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@4855

@vue/language-core

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-core@4855

@vue/language-plugin-pug

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@4855

@vue/language-server

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-server@4855

vue-tsc

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-tsc@4855

@vue/language-service

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-service@4855

@vue/typescript-plugin

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@4855

commit: 7b0ebb2

Copy link
Collaborator

@davidmatter davidmatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KazariEX KazariEX merged commit 5a02676 into vuejs:master Sep 18, 2024
5 checks passed
@KazariEX KazariEX deleted the fix/destructure-props-null-scope branch September 21, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants