fix(language-service): initialize scope with null prototype object (#…

…4855)
vuejs · Sep 18, 2024 · 5a02676 · 5a02676
1 parent 66c9ab6
commit 5a02676
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/packages/language-server/tests/inlayHints.spec.ts b/packages/language-server/tests/inlayHints.spec.ts
@@ -186,6 +186,28 @@ describe('Definitions', async () => {
  `);
  });
 
+ it('#4855', async () => {
+ expect(
+ await requestInlayHintsResult('fixture.vue', 'vue', `
+ <script setup lang="ts">
+ import { toString } from './utils';
+
+ const { foo } = defineProps<{ foo: string }>();
+ console.log(foo);
+ </script>
+ `)
+ ).toMatchInlineSnapshot(`
+ "
+ <script setup lang="ts">
+ import { toString } from './utils';
+
+ const { foo } = defineProps<{ foo: string }>();
+ console.log(/* props. */foo);
+ </script>
+ "
+ `);
+ });
+
  const openedDocuments: TextDocument[] = [];
 
  afterEach(async () => {

diff --git a/packages/language-service/lib/plugins/vue-inlayhints.ts b/packages/language-service/lib/plugins/vue-inlayhints.ts
@@ -107,7 +107,7 @@ export function findDestructuredProps(
  ast: ts.SourceFile,
  props: Set<string>
 ) {
- const rootScope: Scope = {};
+ const rootScope: Scope = Object.create(null);
  const scopeStack: Scope[] = [rootScope];
  let currentScope: Scope = rootScope;
  const excludedIds = new WeakSet<ts.Identifier>();