Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get missing licenses from GitHub API #113

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Get missing licenses from GitHub API #113

merged 3 commits into from
Dec 13, 2023

Conversation

vtourraine
Copy link
Owner

  • Add GitHubAPI to get licenses from GitHub API
  • Update AcknowListViewController to get missing licenses from GitHub API, with new canFetchLicenseFromGitHub property to disable this behavior

@vtourraine vtourraine merged commit a2df5c3 into main Dec 13, 2023
1 check passed
@vtourraine vtourraine mentioned this pull request Dec 15, 2023
Closed
@mischa-hildebrand
Copy link

@vtourraine Nice, thank you!
Note that the functionality to fetch the LICENSE files from the GitHub repos is only implemented for UIKit so far (on the AcknowListViewController). The SwiftUI view doesn't support this yet and still opens the repo's main page in Safari. Would probably make sense to extract this logic from the view and reuse it.

@vtourraine
Copy link
Owner Author

@mischa-hildebrand Thank you for the feedback! I’ve just opened a pull request adding support for SwiftUI: #116. Feel free to test it, and let me know if you have any suggestions.

@vtourraine vtourraine deleted the fetch-license branch January 9, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtourraine @mischa-hildebrand