Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to see License Page in Swift 5 #108

Closed
jobinsjohn opened this issue Mar 1, 2023 · 3 comments
Closed

Not able to see License Page in Swift 5 #108

jobinsjohn opened this issue Mar 1, 2023 · 3 comments
Labels

Comments

@jobinsjohn
Copy link

jobinsjohn commented Mar 1, 2023

I am using Acknowlist to show the licenses of the SPM packages that I am using. The view gives a list of the packages that I am using like as shown below

simulator_screenshot_A0FE8C2F-06E4-42C9-AF87-FC7B8C2C22C6

But when I tap on one of the entries, I am taken to the default landing page of the repository rather than going into the license page as shown below.

For example if I tap on "acknowlist", then the following page is shown

simulator_screenshot_87B5C198-0DC2-4E6E-B09C-BE58F62EF9F3

Is this the expected behavior?

@vtourraine
Copy link
Owner

Hello @jobinsjohn 👋

Yes, this is the expected behavior. SPM doesn’t specify licences, so AcknowList doesn’t know what to display and falls back to the repo URL (where one can usually find the licence).

If you really want to embed the licence for your SPM dependencies, you’ll have to specify them from your code, by customizing the acknowledgements property in your AcknowListViewController.

@vtourraine
Copy link
Owner

Hello @jobinsjohn,

Sorry to bring back this old issue, but it turns out that I found a solution for the problem you reported here. As you can see in #113, AcknowList will now try to fetch the missing libraries from the GitHub API. Not perfect, but a significant improvement in most cases.

I haven’t released it as a new version yet. You can try it on the main branch. Let me know if you have any feedback.

@mischa-hildebrand
Copy link

Note: Only works with UIKit so far, not with SwiftUI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants