Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve vtgate logging for buffering #17654

Merged
merged 2 commits into from
Jan 30, 2025

suppress keyspace event resolved logging for every shard

74a413c
Select commit
Loading
Failed to load commit list.
Merged

Improve vtgate logging for buffering #17654

suppress keyspace event resolved logging for every shard
74a413c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 30, 2025 in 0s

67.75% (-0.02%) compared to 9c6c380

View this Pull Request on Codecov

67.75% (-0.02%) compared to 9c6c380

Details

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.75%. Comparing base (9c6c380) to head (74a413c).

Files with missing lines Patch % Lines
go/vt/discovery/keyspace_events.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17654      +/-   ##
==========================================
- Coverage   67.76%   67.75%   -0.02%     
==========================================
  Files        1586     1586              
  Lines      255763   255764       +1     
==========================================
- Hits       173315   173285      -30     
- Misses      82448    82479      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.