-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve vtgate logging for buffering #17654
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: deepthi <[email protected]>
Signed-off-by: deepthi <[email protected]>
deepthi
added
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Component: Query Serving
Component: Observability
Pull requests that touch tracing/metrics/monitoring
labels
Jan 30, 2025
deepthi
requested review from
harshit-gangal,
systay,
frouioui and
GuptaManan100
as code owners
January 30, 2025 00:03
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Jan 30, 2025
deepthi
removed
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Jan 30, 2025
mattlord
approved these changes
Jan 30, 2025
deepthi
removed
the
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
label
Jan 30, 2025
frouioui
approved these changes
Jan 30, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17654 +/- ##
==========================================
- Coverage 67.76% 67.75% -0.02%
==========================================
Files 1586 1586
Lines 255763 255764 +1
==========================================
- Hits 173315 173285 -30
- Misses 82448 82479 +31 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Observability
Pull requests that touch tracing/metrics/monitoring
Component: Query Serving
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #17294 we moved some of the buffering related logs to level 2. However, we do want to always see Starting/Stopping/Draining messages which are emitted once per shard. What we wanted to suppress were the "disruption in shard resolved" type messages which we were logging up to n^2 times if you are concurrently running PRS on n shards.
Changes in this PR
No back ports are required since the original PR was not back ported.
Related Issue(s)
#17294
Checklist
Deployment Notes