Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve vtgate logging for buffering #17654

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

deepthi
Copy link
Member

@deepthi deepthi commented Jan 30, 2025

Description

In #17294 we moved some of the buffering related logs to level 2. However, we do want to always see Starting/Stopping/Draining messages which are emitted once per shard. What we wanted to suppress were the "disruption in shard resolved" type messages which we were logging up to n^2 times if you are concurrently running PRS on n shards.

Changes in this PR

  • Continue to log Starting/Stopping/Draining once per shard
  • Move "keyspace event resolved" logs per-shard to level 2
  • add a log line for "keyspace is consistent" per keyspace, whenever it becomes consistent

No back ports are required since the original PR was not back ported.

Related Issue(s)

#17294

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@deepthi deepthi added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving Component: Observability Pull requests that touch tracing/metrics/monitoring labels Jan 30, 2025
Copy link
Contributor

vitess-bot bot commented Jan 30, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jan 30, 2025
@deepthi deepthi changed the title Ds fix buffer logs Improve vtgate logging for buffering Jan 30, 2025
@github-actions github-actions bot added this to the v22.0.0 milestone Jan 30, 2025
@deepthi deepthi removed NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jan 30, 2025
@deepthi deepthi removed the NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work label Jan 30, 2025
@deepthi deepthi requested review from notfelineit and removed request for systay January 30, 2025 00:15
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.75%. Comparing base (9c6c380) to head (74a413c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/discovery/keyspace_events.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17654      +/-   ##
==========================================
- Coverage   67.76%   67.75%   -0.02%     
==========================================
  Files        1586     1586              
  Lines      255763   255764       +1     
==========================================
- Hits       173315   173285      -30     
- Misses      82448    82479      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deepthi deepthi merged commit 53396cd into vitessio:main Jan 30, 2025
105 of 116 checks passed
@deepthi deepthi deleted the ds-fix-buffer-logs branch January 30, 2025 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Observability Pull requests that touch tracing/metrics/monitoring Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants