Skip to content

make good cost way more sensible and adjust thresholds#5807

Open
erh wants to merge 13 commits intoviamrobotics:mainfrom
erh:20260228-good-cost-work
Open

make good cost way more sensible and adjust thresholds#5807
erh wants to merge 13 commits intoviamrobotics:mainfrom
erh:20260228-good-cost-work

Conversation

@erh
Copy link
Member

@erh erh commented Mar 1, 2026

@michaellee1019 just an FYI - this should fix the wine cart issue

@erh erh requested review from dgottlieb and michaellee1019 March 1, 2026 02:02
@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Mar 1, 2026
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Mar 1, 2026
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Mar 1, 2026
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Mar 1, 2026
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Mar 1, 2026
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Mar 1, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2026

Availability

Scene # viamrobotics:main erh:20260228-good-cost-work Percent Improvement Health
1 100% 100% 0%
2 100% 100% 0%
3 100% 100% 0%
4 100% 100% 0%
5 100% 100% 0%
6 100% 100% 0%
7 100% 100% 0%
8 100% 100% 0%
9 100% 100% 0%
10 100% 100% 0%
11 100% 100% 0%

Quality

Scene # viamrobotics:main erh:20260228-good-cost-work Percent Improvement Probability of Improvement Health
1 1.31±0.00 1.31±0.00 0% 50%
2 0.94±0.01 0.94±0.01 0% 60%
3 6.01±0.29 6.13±0.00 -2% 34%
4 1.98±0.27 1.98±0.27 -0% 50%
5 8.68±1.96 8.58±2.12 1% 51%
6 8.60±2.52 9.01±2.46 -5% 45%
7 1.95±0.38 1.95±0.38 -0% 50%
8 0.94±0.01 0.94±0.01 1% 72%
9 4.17±0.00 4.53±0.37 -9% 16%
10 12.63±0.03 12.63±0.03 -0% 50%
11 0.62±0.00 0.62±0.00 -0% 42%

Performance

Scene # viamrobotics:main erh:20260228-good-cost-work Percent Improvement Probability of Improvement Health
1 0.02±0.00 0.02±0.00 4% 80%
2 0.02±0.00 0.04±0.02 -87% 19%
3 0.02±0.00 0.02±0.00 31% 100%
4 0.24±0.04 0.26±0.03 -9% 34%
5 1.40±0.16 1.07±0.24 24% 88%
6 1.61±0.36 1.32±0.36 18% 71%
7 1.32±0.09 0.72±0.08 46% 100%
8 0.02±0.00 0.03±0.00 -19% 11%
9 1.72±0.11 1.25±0.33 28% 91%
10 3.52±0.41 3.52±0.38 -0% 50%
11 0.54±0.08 0.52±0.04 3% 57%

The above data was generated by running scenes defined in the motion-testing repository
The SHA1 for viamrobotics:main is: 56429e7f3402c283974c725fd2725a0b654ff64c
The SHA1 for erh:20260228-good-cost-work is: 56429e7f3402c283974c725fd2725a0b654ff64c

  • 11 samples were taken for each scene

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test This pull request is marked safe to test from a trusted zone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants