Skip to content

RSDK-13122 — Refactor non-transform builtins off of videosourcewrappers#5722

Draft
hexbabe wants to merge 6 commits intoviamrobotics:mainfrom
hexbabe:RSDK-13122-videosourcewrappers
Draft

RSDK-13122 — Refactor non-transform builtins off of videosourcewrappers#5722
hexbabe wants to merge 6 commits intoviamrobotics:mainfrom
hexbabe:RSDK-13122-videosourcewrappers

Conversation

@hexbabe
Copy link
Member

@hexbabe hexbabe commented Feb 9, 2026

Branch based on https://github.com/hexbabe/sean-rdk/tree/RSDK-13060 of RSDK-13060 (part 2/2) — Remove GetImage and RenderFrame fully from Go SDK/RDK fame

This PR migrates all non-transform (fake, image_file, and ffmpeg) cameras off of the deprecated videosourcewrappers implementation and into more "normal" cameras. Transform cameras and the deletion of videosourcewrappers will happen on this stacked PR: #5748

Manual Tests

On my Macbook

fake camera

  • No attributes specified, refresh 1 sec
  • No attributes specified, live stream
  • animated set to true, refresh 1 sec
  • animated set to true, live stream
  • height = 480, width = 640, live stream and refresh 1 sec work with reconfigured new resolution
  • model set to true, run go script that logs Properties returned: 2026-02-12T18:41:08.114Z INFO client go-sdk-client/camera_stuff.go:107 camera properties: supports_pcd=true image_type= mime_types=[] frame_rate=0.000000 intrinsic_params=&{Width:640 Height:480 Fx:821.32642889 Fy:821.68607359 Ppx:494.95941428 Ppy:370.70529534} distortion_params=&{RadialK1:0.11297234 RadialK2:-0.21375332 RadialK3:-0.01584774 TangentialP1:-0.00302002 TangentialP2:0.19969297}
  • model set to false, run go script that logs Properties returned: 2026-02-12T18:41:48.883Z INFO client go-sdk-client/camera_stuff.go:107 camera properties: supports_pcd=true image_type= mime_types=[] frame_rate=0.000000 intrinsic_params=<nil> distortion_params=<nil>
  • "rtp_passthrough": true: verified that This resource will ignore width, height, and animated config params but also verified that with model set to true, the props return correctly.
  • get_point_cloud works, displays the gradient in PCD viewer

image_file

  • Tried all preloaded images pizza, dog, crowd
  • Setting depth_image_file_path to /Users/seanyu/Projects/sean-rdk/.artifact/data/rimage/fakeDM.vnd.viam.dep doesn't work, but this is parity with stable viam-server. Filed a bug ticket for App https://viam.atlassian.net/browse/APP-15228
  • Setting pointcloud_file_path to /Users/seanyu/Projects/sean-rdk/.artifact/data/pointcloud/bun000.pcd works, I see the bunny
  • Setting color_image_file_path to /Users/seanyu/Projects/sean-rdk/.artifact/data/transform/align-test-1615761793_color.png works

ffmpeg

  • Setting video_path to rtsp://0.0.0.0:8554/live.stream with a local mediamtx server works!

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Feb 9, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2026

Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!

component function
audio_in Properties
audio_out Properties
base IsMoving
button Push
genericcomponent DoCommand
board GPIOPinByName
camera Properties
encoder Properties
motor IsMoving
sensor Readings
servo Position
arm EndPosition
audio MediaProperties
gantry Lengths
gripper IsMoving
input_controller Controls
movement_sensor LinearAcceleration
power_sensor Power
pose_tracker Poses
genericservice DoCommand
motion GetPose
vision GetProperties

@hexbabe hexbabe closed this Feb 11, 2026
@hexbabe hexbabe reopened this Feb 12, 2026
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Feb 12, 2026
@hexbabe hexbabe force-pushed the RSDK-13122-videosourcewrappers branch from 53c263e to 3e2e729 Compare February 12, 2026 19:47
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Feb 12, 2026
@hexbabe hexbabe changed the title RSDK-13122 — Refactor and remove videosourcewrappers RSDK-13122 — Refactor non-transform builtins off of videosourcewrappers Feb 12, 2026
@hexbabe hexbabe force-pushed the RSDK-13122-videosourcewrappers branch from 3e2e729 to 737ace7 Compare February 12, 2026 20:08
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test This pull request is marked safe to test from a trusted zone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants