RSDK-13122 — Refactor non-transform builtins off of videosourcewrappers#5722
Draft
hexbabe wants to merge 6 commits intoviamrobotics:mainfrom
Draft
RSDK-13122 — Refactor non-transform builtins off of videosourcewrappers#5722hexbabe wants to merge 6 commits intoviamrobotics:mainfrom
hexbabe wants to merge 6 commits intoviamrobotics:mainfrom
Conversation
Contributor
|
Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!
|
53c263e to
3e2e729
Compare
3e2e729 to
737ace7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch based on https://github.com/hexbabe/sean-rdk/tree/RSDK-13060 of
RSDK-13060 (part 2/2) — Remove GetImage and RenderFrame fully from Go SDK/RDKfameThis PR migrates all non-transform (
fake,image_file, andffmpeg) cameras off of the deprecatedvideosourcewrappersimplementation and into more "normal" cameras. Transform cameras and the deletion ofvideosourcewrapperswill happen on this stacked PR: #5748Manual Tests
On my Macbook
fakecameraanimatedset to true, refresh 1 secanimatedset to true, live streammodelset to true, run go script that logsPropertiesreturned:2026-02-12T18:41:08.114Z INFO client go-sdk-client/camera_stuff.go:107 camera properties: supports_pcd=true image_type= mime_types=[] frame_rate=0.000000 intrinsic_params=&{Width:640 Height:480 Fx:821.32642889 Fy:821.68607359 Ppx:494.95941428 Ppy:370.70529534} distortion_params=&{RadialK1:0.11297234 RadialK2:-0.21375332 RadialK3:-0.01584774 TangentialP1:-0.00302002 TangentialP2:0.19969297}modelset to false, run go script that logsPropertiesreturned:2026-02-12T18:41:48.883Z INFO client go-sdk-client/camera_stuff.go:107 camera properties: supports_pcd=true image_type= mime_types=[] frame_rate=0.000000 intrinsic_params=<nil> distortion_params=<nil>"rtp_passthrough": true: verified thatThis resource will ignore width, height, and animated config paramsbut also verified that withmodelset to true, the props return correctly.get_point_cloudworks, displays the gradient in PCD viewerimage_filepizza,dog,crowddepth_image_file_pathto/Users/seanyu/Projects/sean-rdk/.artifact/data/rimage/fakeDM.vnd.viam.depdoesn't work, but this is parity with stable viam-server. Filed a bug ticket for App https://viam.atlassian.net/browse/APP-15228pointcloud_file_pathto/Users/seanyu/Projects/sean-rdk/.artifact/data/pointcloud/bun000.pcdworks, I see the bunnycolor_image_file_pathto/Users/seanyu/Projects/sean-rdk/.artifact/data/transform/align-test-1615761793_color.pngworksffmpegrtsp://0.0.0.0:8554/live.streamwith a local mediamtx server works!