Skip to content

DATA-3948 Update CLI to use new binary data id type #4879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vijayvuyyuru merged 4 commits into from
Apr 10, 2025
Merged

DATA-3948 Update CLI to use new binary data id type #4879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
634840f
update CLI
vijayvuyyuru Mar 28, 2025
5485662
fix lint
vijayvuyyuru Apr 1, 2025
da7372a
lint
vijayvuyyuru Apr 1, 2025
76b5271
update ocmments
vijayvuyyuru Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 18 additions & 59 deletions cli/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,19 +213,9 @@ var dataTagByIDsFlags = []cli.Flag{
Usage: "comma separated tags to add/remove to the data",
Required: true,
},
&cli.StringFlag{
Name: generalFlagOrgID,
Usage: "org ID to which data belongs",
Required: true,
},
&cli.StringFlag{
Name: dataFlagLocationID,
Usage: "location ID to which data belongs",
Required: true,
},
&cli.StringSliceFlag{
Name: dataFlagFileIDs,
Usage: "comma separated file IDs of data belonging to specified org and location",
Name: dataFlagBinaryDataIDs,
Usage: "comma separated binary data IDs",
Required: true,
},
}
Expand Down Expand Up @@ -1253,24 +1243,24 @@ var app = &cli.App{
Subcommands: []*cli.Command{
{
Name: "ids",
Usage: "adds or removes tags from binary data by file ids for a given org and location",
Usage: "adds or removes tags from binary data by binary data ids for a given org and location",
UsageText: createUsageText("data tag ids", nil, true, false),
HideHelpCommand: true,
Subcommands: []*cli.Command{
{
Name: "add",
Usage: "adds tags to binary data by file ids for a given org and location",
Usage: "adds tags to binary data by binary data ids for a given org and location",
UsageText: createUsageText(
"data tag ids add", []string{generalFlagTags, generalFlagOrgID, dataFlagLocationID, dataFlagFileIDs}, false, false,
"data tag ids add", []string{generalFlagTags, dataFlagBinaryDataIDs}, false, false,
),
Flags: dataTagByIDsFlags,
Action: createCommandWithT[dataTagByIDsArgs](DataTagActionByIds),
},
{
Name: "remove",
Usage: "removes tags from binary data by file ids for a given org and location",
Usage: "removes tags from binary data by binary data ids for a given org and location",
UsageText: createUsageText(
"data tag ids remove", []string{generalFlagTags, generalFlagOrgID, dataFlagLocationID, dataFlagFileIDs}, false, false,
"data tag ids remove", []string{generalFlagTags, dataFlagBinaryDataIDs}, false, false,
),
Flags: dataTagByIDsFlags,
Action: createCommandWithT[dataTagByIDsArgs](DataTagActionByIds),
Expand Down Expand Up @@ -1425,29 +1415,19 @@ var app = &cli.App{
Subcommands: []*cli.Command{
{
Name: "ids",
Usage: "adds binary data with file IDs in a single org and location to dataset",
Usage: "adds binary data with binary data ids in a single org and location to dataset",
UsageText: createUsageText(
"dataset data add ids", []string{datasetFlagDatasetID, generalFlagOrgID, dataFlagLocationID, dataFlagFileIDs}, false, false,
"dataset data add ids", []string{datasetFlagDatasetID, dataFlagBinaryDataIDs}, false, false,
),
Flags: []cli.Flag{
&cli.StringFlag{
Name: datasetFlagDatasetID,
Usage: "dataset ID to which data will be added",
Required: true,
},
&cli.StringFlag{
Name: generalFlagOrgID,
Usage: "org ID to which data belongs",
Required: true,
},
&cli.StringFlag{
Name: dataFlagLocationID,
Usage: "location ID to which data belongs",
Required: true,
},
&cli.StringSliceFlag{
Name: dataFlagFileIDs,
Usage: "file IDs of data belonging to specified org and location",
Name: dataFlagBinaryDataIDs,
Usage: "binary data IDs of data belonging to specified org and location",
Required: true,
},
},
Expand Down Expand Up @@ -1484,29 +1464,19 @@ var app = &cli.App{
Subcommands: []*cli.Command{
{
Name: "ids",
Usage: "removes binary data with file IDs in a single org and location from a dataset",
Usage: "removes binary data with binary data ids in a single org and location from a dataset",
UsageText: createUsageText(
"dataset data remove ids", []string{datasetFlagDatasetID, generalFlagOrgID, dataFlagLocationID, dataFlagFileIDs}, false, false,
"dataset data remove ids", []string{datasetFlagDatasetID, dataFlagBinaryDataIDs}, false, false,
),
Flags: []cli.Flag{
&cli.StringFlag{
Name: datasetFlagDatasetID,
Usage: "dataset ID from which data will be removed",
Required: true,
},
&cli.StringFlag{
Name: generalFlagOrgID,
Usage: "org ID to which data belongs",
Required: true,
},
&cli.StringFlag{
Name: dataFlagLocationID,
Usage: "location ID to which data belongs",
Required: true,
},
&cli.StringSliceFlag{
Name: dataFlagFileIDs,
Usage: "file IDs of data belonging to specified org and location",
Name: dataFlagBinaryDataIDs,
Usage: "binary data IDs of data belonging to specified org and location",
Required: true,
},
},
Expand Down Expand Up @@ -2898,8 +2868,7 @@ This won't work unless you have an existing installation of our GitHub app on yo
Name: "infer",
Usage: "run cloud hosted inference on an image",
UsageText: createUsageText("infer", []string{
generalFlagOrgID, inferenceFlagFileOrgID, inferenceFlagFileID,
inferenceFlagFileLocationID, inferenceFlagModelOrgID, inferenceFlagModelName, inferenceFlagModelVersion,
generalFlagOrgID, inferenceFlagBinaryDataID, inferenceFlagModelOrgID, inferenceFlagModelName, inferenceFlagModelVersion,
}, true, false),
Flags: []cli.Flag{
&cli.StringFlag{
Expand All @@ -2908,18 +2877,8 @@ This won't work unless you have an existing installation of our GitHub app on yo
Required: true,
},
&cli.StringFlag{
Name: inferenceFlagFileOrgID,
Usage: "organization ID that owns the file to run inference on",
Required: true,
},
&cli.StringFlag{
Name: inferenceFlagFileID,
Usage: "file ID of the file to run inference on",
Required: true,
},
&cli.StringFlag{
Name: inferenceFlagFileLocationID,
Usage: "location ID of the file to run inference on",
Name: inferenceFlagBinaryDataID,
Usage: "binary data ID of the image to run inference on",
Required: true,
},
&cli.StringFlag{
Expand Down
Loading
Loading