Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RSDK-9019][RSDK-9020][RSDK-9021][RSDK-9025] remove movement and power sensors #4537

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

martha-johnston
Copy link
Contributor

@martha-johnston martha-johnston commented Nov 7, 2024

This PR removes the builtins for mpu6050, adxl345, dual gps, gpsnmea, gpsrtk, and imuwit movement sensors, and the in a power sensors. The components are all replaced with modules in the registry (both linked below). All modules pass tests and build successfully in their supported architectures.

mpu6050: module & registry
adxl: module & registry
imuwit: module & registry
ina: module & registry

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Nov 7, 2024
@martha-johnston martha-johnston changed the title remove mpu6050 from builtin remove sensors Nov 7, 2024
@martha-johnston martha-johnston changed the title remove sensors [RSDK-9019][RSDK-9020][RSDK-9021][RSDK-9022][RSDK-9025] Nov 7, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 7, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 7, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 7, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 7, 2024
@martha-johnston martha-johnston marked this pull request as ready for review November 7, 2024 22:03
@martha-johnston martha-johnston requested review from a team and oliviamiller and removed request for a team November 7, 2024 22:06
@martha-johnston martha-johnston changed the title [RSDK-9019][RSDK-9020][RSDK-9021][RSDK-9022][RSDK-9025] [RSDK-9019][RSDK-9020][RSDK-9021][RSDK-9025] Nov 7, 2024
@martha-johnston martha-johnston changed the title [RSDK-9019][RSDK-9020][RSDK-9021][RSDK-9025] [RSDK-9019][RSDK-9020][RSDK-9021][RSDK-9025] remove movement and power sensors Nov 8, 2024
@martha-johnston
Copy link
Contributor Author

blocked from merging until migration script is fixed to not migrate esp32 components

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants