Bump go-graphviz to compile with -Wno-format-security #3653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
zaporter-work
force-pushed
the
zp/bump-graphviz
branch
from
84bcf4b to
ce1db0b
Compare
viambot
added
safe to test
zaporter-work
changed the title
benjirewis
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps go-graphviz to the newest commit to have goccy/go-graphviz#83
(I accidentally named the commit "initial" because I forgot not all repos squash-and-merge 😢 )
I did this because otherwise I can't compile app and have to keep patching app's go.mod to my own repo because app depends on go-graphviz transitively through rdk and I can't compile graphviz without this cc flag. I'm not sure why other people at viam aren't running into this, but I suspect other people will once they upgrade to go 1.21 or bump gcc or use linux or some combination of the above.