Update validation bip #5
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcalvinalvin
force-pushed
the
2024-08-29-update-validation-bip
branch
2 times, most recently
from
e52bc26 to
3825ebb
Compare
kcalvinalvin
force-pushed
the
2024-08-29-update-validation-bip
branch
from
3825ebb to
5c7afa0
Compare
| @@ -65,7 +65,7 @@ string, it's "5574726565786f5631". (The resulting 64 byte output is | |||
| 5b832db8ca26c25be1c542d6cceddda8c145615cff5c35727fb3462610807e20ae534dc3f64299199931772e03787d18156eb3151e0ed1b3098bdc8445861885) | |||
There was a problem hiding this comment.
It seems right
$ echo -n UtreexoV1 | sha512sum
5b832db8ca26c25be1c542d6cceddda8c145615cff5c35727fb3462610807e20ae534dc3f64299199931772e03787d18156eb3151e0ed1b3098bdc8445861885
| @@ -138,14 +138,14 @@ as all proofs are with respect to the merkle roots of the entire set. | |||
| For this reason, we define which UTXOs are not inserted to the accumulator. Any | |||
| variations here will result in Utreexo nodes with incompatible proofs. | |||
|
|
|||
| ##### Provably unspendable transaction outputs | |||
| ## Provably unspendable transaction outputs | |||
There was a problem hiding this comment.
This section and the one below it should be inside the previous one, no? Like three # since this lists the outputs that are excluded.
| defined in bip ???. Deletions are order-independent. | ||
| 2: Batch add all non-excluded outputs in the order they're included in the | ||
| Bitcoin block. | ||
| 1. Verify that the UTXOs that were spent in the block. Raise error if the verification fails. |
There was a problem hiding this comment.
This phrase sounds weird. It tells us to validate the scripts for transactions spending those outputs?
| This field is added to commit to the locking script of the UTXO. With current | ||
| nodes, this is stored in the UTXO set but since we receive this in the proof | ||
| from our peers, we need to commit to this value to avoid malicious peers that | ||
| may send over the wrong locking script. | ||
|
|
||
| #### Hash function | ||
| ## Hash function | ||
| The leaf data is hashed with SHA-512/256, which gives us a 32 byte hash. |
There was a problem hiding this comment.
Should have a link to a benchmark here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.