Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made plasma optional for export h5m with pymoab #828

Merged
merged 3 commits into from
May 3, 2021

Conversation

shimwell
Copy link
Collaborator

@shimwell shimwell commented Apr 29, 2021

Proposed changes

This PR adds a flag for including the plasma or not in the PyMoab

As requested in issue #824

@billingsley-john could you take a look and add a test to check this works as you would like

Types of changes

What types of changes does your code introduce to the Paramak?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Pep8 applied
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@shimwell shimwell marked this pull request as draft April 29, 2021 16:16
@shimwell shimwell marked this pull request as ready for review May 3, 2021 18:12
@shimwell shimwell merged commit d80c9e5 into develop May 3, 2021
@shimwell shimwell deleted the making_include_plasma_optional branch May 3, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plasma component not ignored in Reactor() class during simulation
1 participant