Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

event assignment default #20

Merged
merged 6 commits into from
Sep 12, 2024

Conversation

Keyrxng
Copy link
Contributor

@Keyrxng Keyrxng commented Sep 12, 2024

Resolves #19

  • fallback to assignment event timestamp if the bot has not intervened since the contributor started the task via any method.
  • updated tests

Copy link
Contributor

Unused types (1)

Filename types
src/types/github-types.ts Label

Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where's QA link? Code looks fine.

@Keyrxng
Copy link
Contributor Author

Keyrxng commented Sep 12, 2024

@0x4007
Copy link
Member

0x4007 commented Sep 12, 2024

Is there a simple way you can prove that this works in some mock example with shorter timeouts? Like link a GitHub issue

@Keyrxng
Copy link
Contributor Author

Keyrxng commented Sep 12, 2024

Is there a simple way you can prove that this works in some mock example with shorter timeouts? Like link a GitHub issue

ubq-testing/command-start-stop#19 < this was created on the 4th, so last week. My config settings are the default 3.5 and 7 days respectively.

The issue is filled with usage of /start but no official start comment from the bot. Is this enough or you mean run a very specific couple of tests?

image

@gentlementlegen
Copy link
Member

I think what we are trying to solve is users that self assign through the UI. There is no start message from the bot (there is, but it is different). In this scenario I noticed that the reminders and unassigns were not working.
Example: https://github.com/ubiquibot/user-activity-watcher/actions/runs/10835091739/job/30065821594#step:5:53

@Keyrxng
Copy link
Contributor Author

Keyrxng commented Sep 12, 2024

here is a clear cut example from that same run.

self assigned via the UI, bot kicked me.

image
image

@Keyrxng
Copy link
Contributor Author

Keyrxng commented Sep 12, 2024

Here is a run I just done with a 5m warning and 10m disqualification

https://github.com/ubq-testing/user-activity-watcher/actions/runs/10835251567/job/30066345978
image

@gentlementlegen gentlementlegen self-requested a review September 12, 2024 17:07
Copy link
Member

@gentlementlegen gentlementlegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code seems to be indented with 4 spaces instead of the usual 2 spaces.

@0x4007
Copy link
Member

0x4007 commented Sep 12, 2024

Fix CI and lets merge.

@Keyrxng
Copy link
Contributor Author

Keyrxng commented Sep 12, 2024

fixing ci rn, new log means update tests. Tedious but essential

The code seems to be indented with 4 spaces instead of the usual 2 spaces.

Yeah idk why that happens in certain repos, I always have format-on-save enabled and it works right most of the time. It's not like there is a config file in this repo that's affecting it either, weird af.

@0x4007 0x4007 merged commit 3684bec into ubiquity-os-marketplace:development Sep 12, 2024
2 checks passed
@ubiquity-os ubiquity-os bot mentioned this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong "start time" target
3 participants