-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
event assignment default #20
event assignment default #20
Conversation
Unused types (1)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where's QA link? Code looks fine.
My bad QA: https://github.com/ubq-testing/user-activity-watcher/actions/runs/10834775241/job/30064760402 |
Is there a simple way you can prove that this works in some mock example with shorter timeouts? Like link a GitHub issue |
ubq-testing/command-start-stop#19 < this was created on the 4th, so last week. My config settings are the default The issue is filled with usage of |
I think what we are trying to solve is users that self assign through the UI. There is no start message from the bot (there is, but it is different). In this scenario I noticed that the reminders and unassigns were not working. |
Here is a run I just done with a https://github.com/ubq-testing/user-activity-watcher/actions/runs/10835251567/job/30066345978 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code seems to be indented with 4 spaces instead of the usual 2 spaces.
Fix CI and lets merge. |
fixing ci rn, new log means update tests. Tedious but essential
Yeah idk why that happens in certain repos, I always have |
Resolves #19