Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong "start time" target #19

Closed
0x4007 opened this issue Sep 12, 2024 · 3 comments · Fixed by #20
Closed

Wrong "start time" target #19

0x4007 opened this issue Sep 12, 2024 · 3 comments · Fixed by #20

Comments

@0x4007
Copy link
Member

0x4007 commented Sep 12, 2024

It appears as though the software checks for the metadata from the /start comment.

This is incorrect because there are various ways to assign people without that command.

Check the timeline for assign events and target this timestamp.

The correct logic can be lifted from bot v1.

Example of it not working as expected: ubiquity-os-marketplace/text-conversation-rewards#92

@0x4007
Copy link
Member Author

0x4007 commented Sep 12, 2024

I set this to urgent because this unassignment capability has an outsized effect on our organization's throughput.

I think that a ton of tasks get "reserved" and removed from the DevPool from people who forget to do them.

This reminds, and even offers a disincentive (disqualification) if contributors don't fulfill their promises.

Copy link
Contributor

ubiquity-os bot commented Sep 12, 2024

@Keyrxng the deadline is at Thu, Sep 12, 11:24 AM UTC

Copy link
Contributor

ubiquity-os bot commented Sep 12, 2024

[ 100 WXDAI ]

@Keyrxng
Contributions Overview
View Contribution Count Reward
Issue Task 1 100
Review Comment 6 0
Conversation Incentives
Comment Formatting Relevance Reward
Resolves #19 - fallback to assignment event timestamp if the bo…
0
content:
  p:
    symbols:
      \b\w+\b:
        count: 2
        multiplier: 0
    score: 1
  ul:
    symbols:
      \b\w+\b:
        count: 22
        multiplier: 0
    score: 1
  li:
    symbols:
      \b\w+\b:
        count: 2
        multiplier: 0
    score: 1
multiplier: 0
0.8 -
My bad QA: https://github.com/ubq-testing/user-activity-watche…
0
content:
  p:
    symbols:
      \b\w+\b:
        count: 24
        multiplier: 0.2
    score: 1
  img:
    symbols:
      \b\w+\b:
        count: 1
        multiplier: 0.2
    score: 0
multiplier: 0
1 -
https://github.com/ubq-testing/command-start-stop/issues/19 <…
0
content:
  p:
    symbols:
      \b\w+\b:
        count: 60
        multiplier: 0.2
    score: 1
  code:
    symbols:
      \b\w+\b:
        count: 1
        multiplier: 0.2
    score: 1
  img:
    symbols:
      \b\w+\b:
        count: 1
        multiplier: 0.2
    score: 0
multiplier: 0
1 -
here is a clear cut example from that same run. self assigned v…
0
content:
  p:
    symbols:
      \b\w+\b:
        count: 18
        multiplier: 0.2
    score: 1
  img:
    symbols:
      \b\w+\b:
        count: 1
        multiplier: 0.2
    score: 0
multiplier: 0
1 -
Here is a run I just done with a `5m` warning and `1…
0
content:
  p:
    symbols:
      \b\w+\b:
        count: 27
        multiplier: 0.2
    score: 1
  code:
    symbols:
      \b\w+\b:
        count: 1
        multiplier: 0.2
    score: 1
  img:
    symbols:
      \b\w+\b:
        count: 1
        multiplier: 0.2
    score: 0
multiplier: 0
1 -
fixing ci rn, new log means update tests. Tedious but essential …
0
content:
  p:
    symbols:
      \b\w+\b:
        count: 53
        multiplier: 0.2
    score: 1
  code:
    symbols:
      \b\w+\b:
        count: 3
        multiplier: 0.2
    score: 1
multiplier: 0
1 -

[ 16.528 WXDAI ]

@0x4007
Contributions Overview
View Contribution Count Reward
Issue Specification 1 10.02
Issue Comment 1 4.158
Review Comment 3 2.35
Conversation Incentives
Comment Formatting Relevance Reward
It appears as though the software checks for the metadata from t…
10.02
content:
  p:
    symbols:
      \b\w+\b:
        count: 62
        multiplier: 0.1
    score: 1
multiplier: 3
1 10.02
I set this to urgent because this unassignment capability has an…
5.94
content:
  p:
    symbols:
      \b\w+\b:
        count: 54
        multiplier: 0.2
    score: 1
multiplier: 1
0.7 4.158
Where's QA link? Code looks fine.
0.52
content:
  p:
    symbols:
      \b\w+\b:
        count: 7
        multiplier: 0.1
    score: 1
multiplier: 1
1 0.52
Is there a simple way you can prove that this works in some mock…
1.44
content:
  p:
    symbols:
      \b\w+\b:
        count: 23
        multiplier: 0.1
    score: 1
multiplier: 1
1 1.44
Fix CI and lets merge.
0.39
content:
  p:
    symbols:
      \b\w+\b:
        count: 5
        multiplier: 0.1
    score: 1
multiplier: 1
1 0.39

[ 4.79 WXDAI ]

@gentlementlegen
Contributions Overview
View Contribution Count Reward
Review Comment 3 4.79
Conversation Incentives
Comment Formatting Relevance Reward
The code seems to be indented with 4 spaces instead of the usual…
1
content:
  p:
    symbols:
      \b\w+\b:
        count: 15
        multiplier: 0.1
    score: 1
multiplier: 1
1 1
Should use the logger, and indent seems wrong.
0.59
content:
  p:
    symbols:
      \b\w+\b:
        count: 8
        multiplier: 0.1
    score: 1
multiplier: 1
1 0.59
I think what we are trying to solve is users that self assign th…
3.2
content:
  p:
    symbols:
      \b\w+\b:
        count: 59
        multiplier: 0.1
    score: 1
multiplier: 1
1 3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants