Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: command wallet #2

Merged

Conversation

gentlementlegen
Copy link
Member

@gentlementlegen
Copy link
Member Author

QA run: Meniole#5 (comment)

@rndquu
Copy link
Member

rndquu commented Jun 25, 2024

@gentlementlegen Could you merge gentlementlegen#1 ?

@gentlementlegen
Copy link
Member Author

@rndquu The problem should be solved now, please let me know.

@rndquu rndquu self-requested a review June 27, 2024 14:51
@rndquu
Copy link
Member

rndquu commented Jun 27, 2024

@gentlementlegen Check this comment which registers a none checksummed address. Some libs may not handle such addresses correctly. Perhaps it makes sense to convert addresses to their checksummed versions on saving to DB?

Otherwise works fine.

@gentlementlegen
Copy link
Member Author

@rndquu It seems to also be that way in the current version of the bot. I added a checksum.

README.md Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/handlers/query-wallet.ts Outdated Show resolved Hide resolved
src/handlers/query-wallet.ts Outdated Show resolved Hide resolved
src/plugin.ts Outdated Show resolved Hide resolved
src/plugin.ts Show resolved Hide resolved
@gentlementlegen gentlementlegen requested a review from 0x4007 July 3, 2024 07:45
src/handlers/query-wallet.ts Outdated Show resolved Hide resolved
src/handlers/query-wallet.ts Show resolved Hide resolved
src/plugin.ts Show resolved Hide resolved
src/types/context.ts Show resolved Hide resolved
@0x4007 0x4007 merged commit d7c5761 into ubiquity-os-marketplace:development Jul 8, 2024
2 checks passed
@gentlementlegen gentlementlegen deleted the feat/command-wallet branch July 8, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/wallet command
3 participants