Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change logs to use ubiquity-dao/ubiquibot-logger #4

Closed
gentlementlegen opened this issue Jul 8, 2024 · 22 comments · Fixed by #19
Closed

Change logs to use ubiquity-dao/ubiquibot-logger #4

gentlementlegen opened this issue Jul 8, 2024 · 22 comments · Fixed by #19

Comments

@gentlementlegen
Copy link
Member

gentlementlegen commented Jul 8, 2024

Currently the logs are handled manually with console messages. They should use our logger package to follow our usual display standards and logic.

https://github.com/ubiquity/ubiquibot-logger

C.f. #2 (comment) and #2 (comment)

0x4007 pushed a commit that referenced this issue Jul 8, 2024
@wolfmic
Copy link

wolfmic commented Aug 18, 2024

/wallet 0xFaF2BD96905b7DAf432534FF4Fa75D90A36614eE

Copy link

ubiquityos bot commented Aug 18, 2024

+ Successfully registered wallet address

Copy link

ubiquibot bot commented Aug 18, 2024

+ Successfully registered wallet address

@wolfmic
Copy link

wolfmic commented Aug 18, 2024

/start

Copy link

ubiquityos bot commented Aug 18, 2024

DeadlineSun, Aug 18, 3:58 PM UTC
Registered Wallet 0xFaF2BD96905b7DAf432534FF4Fa75D90A36614eE
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

Copy link

ubiquibot bot commented Aug 18, 2024

Warning! This task was created over 41 days ago. Please confirm that this issue specification is accurate before starting.
DeadlineSun, Aug 18, 3:58 PM UTC
Registered Wallet 0xFaF2BD96905b7DAf432534FF4Fa75D90A36614eE
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@wolfmic
Copy link

wolfmic commented Aug 18, 2024

Since there is context.logger.warn() in two files (plugin.ts and command-parser.ts), should it be replaced with info method or should I wait until warn is getting implemented?

@gentlementlegen
Copy link
Member Author

@wolfmic I think using logger.error instead of warn is fine for now.

@Apetree100122
Copy link

/START

@Apetree100122
Copy link

/start

Copy link
Contributor

ubiquity-os bot commented Oct 7, 2024

Warning! This task was created over 90 days ago. Please confirm that this issue specification is accurate before starting.
Deadline Mon, Oct 7, 8:15 AM UTC
Beneficiary 0xC6DcC5424AE41dec50e9444742f83Cd489D5527a

Tip

  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@ariesgun
Copy link
Contributor

/start

Copy link
Contributor

Warning! This task was created over 100 days ago. Please confirm that this issue specification is accurate before starting.
Deadline Wed, Oct 16, 10:54 PM UTC
Beneficiary 0xE80FC2700ec6faF5f0347a2E7E7798FAf548e1c3

Tip

  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

Copy link
Contributor

ubiquity-os bot commented Oct 16, 2024

Warning! This task was created over 100 days ago. Please confirm that this issue specification is accurate before starting.
Deadline Wed, Oct 16, 10:54 PM UTC
Beneficiary 0xE80FC2700ec6faF5f0347a2E7E7798FAf548e1c3

Tip

  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@0x4007
Copy link
Member

0x4007 commented Oct 16, 2024

@gentlementlegen @whilefoo can one bot be disabled now? Do we just need to empty out one of the configs?

Let's make @ubiquity use production,

and @ubiquity-os, @ubiquity-os-marketplace use development?

@gentlementlegen
Copy link
Member Author

Marketplace needs both otherwise the runs won't work, you will get the installation is disabled error.

@0x4007
Copy link
Member

0x4007 commented Oct 17, 2024

/help

Copy link
Contributor

ubiquity-os bot commented Oct 17, 2024

Available Commands

Command Description Example
/help List all available commands. /help

Copy link
Contributor

Available Commands

Command Description Example
/help List all available commands. /help
/allow Allows the user to modify the given label. /allow @user1 label
/query Returns the user's wallet, access, and multiplier information. /query @UbiquityOS
/start Assign yourself to the issue. /start
/stop Unassign yourself from the issue. /stop
/wallet Register your wallet address for payments. /wallet ubq.eth

Copy link
Contributor

! You are already assigned to this task.

Copy link
Contributor

! All linked pull requests must be closed to generate rewards.

Copy link
Contributor

ubiquity-os-beta bot commented Oct 25, 2024

 [ 50 WXDAI ] 

@ariesgun
Contributions Overview
ViewContributionCountReward
IssueTask150
ReviewComment40
Conversation Incentives
CommentFormattingRelevanceReward
Resolves #4
0
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 2
  wordValue: 0
  result: 0
0.40
Sometimes the test failed because it wasnt able to resolve an EN…
0
content:
  content:
    p:
      score: 0
      elementCount: 2
  result: 0
regex:
  wordCount: 24
  wordValue: 0
  result: 0
0.10
Shall I undo this change then?
0
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 6
  wordValue: 0
  result: 0
0.10
I reverted the changes and the tests also passI reverted the c…
0
content:
  content:
    p:
      score: 0
      elementCount: 2
  result: 0
regex:
  wordCount: 18
  wordValue: 0
  result: 0
0.20

 [ 0.345 WXDAI ] 

@wolfmic
Contributions Overview
ViewContributionCountReward
IssueComment10.345
Conversation Incentives
CommentFormattingRelevanceReward
Since there is `context.logger.warn()` in two files (plu…
1.7
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 28
  wordValue: 0.1
  result: 1.7
0.80.345

 [ 14.918 WXDAI ] 

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueSpecification18.19
IssueComment20.821
ReviewComment95.907
Conversation Incentives
CommentFormattingRelevanceReward
Currently the logs are handled manually with `console` m…
2.73
content:
  content:
    p:
      score: 0
      elementCount: 3
  result: 0
regex:
  wordCount: 49
  wordValue: 0.1
  result: 2.73
18.19
@wolfmic I think using `logger.error` instead of warn is…
0.77
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 11
  wordValue: 0.1
  result: 0.77
0.70.539
Marketplace needs both otherwise the runs won't work, you will g…
0.94
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 14
  wordValue: 0.1
  result: 0.94
0.30.282
If you use the logger you should not have to manually build thes…
1.38
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 22
  wordValue: 0.1
  result: 1.38
0.91.242
Delete comments
0.18
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 2
  wordValue: 0.1
  result: 0.18
0.30.054
```suggestionawait addCommentToIssue(context, …
0.65
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 9
  wordValue: 0.1
  result: 0.65
10.65
```suggestion```
0
content:
  content: {}
  result: 0
regex:
  wordCount: 0
  wordValue: 0.1
  result: 0
0.10
I think it would make more sense to just use `passthrough …
1.28
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 20
  wordValue: 0.1
  result: 1.28
0.81.024
Yes this happens. I guess it's fine for tests, but ideally our R…
1.11
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 17
  wordValue: 0.1
  result: 1.11
0.60.666
@0x4007 What do you think would be the best approach? In the con…
2.05
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 35
  wordValue: 0.1
  result: 2.05
0.40.82
@ariesgun I am okay with the changes, however the `Jest`…
1.11
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 17
  wordValue: 0.1
  result: 1.11
0.50.555
QA: https://github.com/Meniole/command-wallet/issues/5#issuecomm…
1.28
content:
  content:
    p:
      score: 0
      elementCount: 2
  result: 0
regex:
  wordCount: 20
  wordValue: 0.1
  result: 1.28
0.70.896

 [ 2.199 WXDAI ] 

@0x4007
Contributions Overview
ViewContributionCountReward
IssueComment11.17
ReviewComment11.029
Conversation Incentives
CommentFormattingRelevanceReward
@gentlementlegen @whilefoo can one bot be disabled now? Do we ju…
1.95
content:
  content:
    p:
      score: 0
      elementCount: 3
  result: 0
regex:
  wordCount: 33
  wordValue: 0.1
  result: 1.95
0.61.17
I'm not sure if its valid to skip implementing this test tempora…
3.43
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 64
  wordValue: 0.1
  result: 3.43
0.31.029

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants