Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiding The Help Menu #152

Closed
0x4007 opened this issue Oct 17, 2024 · 7 comments · Fixed by #179
Closed

Hiding The Help Menu #152

0x4007 opened this issue Oct 17, 2024 · 7 comments · Fixed by #179

Comments

@0x4007
Copy link
Member

0x4007 commented Oct 17, 2024

We are trying to have dev and prod apps installed across all orgs so they can interface with all GitHub Actions across our orgs. However only one should respond to user actions and commands, hence why we implemented #122

For this effect to be complete, the help menu should only render on those with a config (I just deleted the prod config in ubiquity-os-marketplace)

Available Commands

Command Description Example
/help List all available commands. /help

Originally posted by @ubiquity-os[bot] in ubiquity-os-marketplace/command-wallet#4 (comment)

@gentlementlegen
Copy link
Member

@0x4007 This is because the help is directly embedded within the kernel. Maybe it could be as simple as adding an enabled property at the top of the configuration?

@0x4007
Copy link
Member Author

0x4007 commented Oct 17, 2024

I think much simpler to check specifically for this use-case. No config found means don't render help menu.

Copy link

@gentlementlegen the deadline is at Tue, Oct 29, 6:10 PM UTC

Copy link

A new workroom has been created for this task. Join chat

Copy link

ubiquity-os-beta bot commented Oct 31, 2024

 [ 12 WXDAI ] 

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueTask112
IssueComment10
ReviewComment20
Conversation Incentives
CommentFormattingRelevanceReward
@0x4007 This is because the help is directly embedded within the…
0
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 28
  wordValue: 0
  result: 0
0.90
Added a check to ensure no comment is posted if commands are emp…
0
content:
  content:
    p:
      score: 0
      elementCount: 3
  result: 0
regex:
  wordCount: 47
  wordValue: 0
  result: 0
0.90
It's the kernel so our logger instance does not exist here, but …
0
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 19
  wordValue: 0
  result: 0
0.60

 [ 19.988 WXDAI ] 

@0x4007
Contributions Overview
ViewContributionCountReward
IssueSpecification118.42
IssueComment11.152
ReviewComment10.416
Conversation Incentives
CommentFormattingRelevanceReward
We are trying to have dev and prod apps installed across all org…
6.14
content:
  content:
    p:
      score: 0
      elementCount: 6
    h3:
      score: 1
      elementCount: 1
    em:
      score: 0
      elementCount: 1
  result: 1
regex:
  wordCount: 103
  wordValue: 0.1
  result: 5.14
118.42
I think much simpler to check specifically for this use-case. No…
1.28
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 20
  wordValue: 0.1
  result: 1.28
0.91.152
I thought we use our logger instead?
0.52
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 7
  wordValue: 0.1
  result: 0.52
0.80.416

@gentlementlegen
Copy link
Member

@0x4007 I got Ubiquiscammed!

Copy link

! Error: HttpError: Resource not accessible by integration - https://docs.github.com/rest/issues/comments#create-an-issue-comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants