Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust keycloak_required_action resource to not use metaparameter alias #321

Conversation

TuningYourCode
Copy link
Contributor

This PR will adjust the keycloak_required_action resource that it no longer uses the alias metaparameter which leads to problems if you want to manage the same required action on multiple realms.

The github issue #320 shows the exact code and error. I tested serveral ways but the current version does not allow to manage the same required action on multiple realms.

Fixes #320

@TuningYourCode TuningYourCode force-pushed the fix-keycloak-required-action-with-multiple-realms branch 2 times, most recently from 79c2af0 to aa59cf0 Compare September 24, 2024 17:24
@TuningYourCode TuningYourCode force-pushed the fix-keycloak-required-action-with-multiple-realms branch from 0b15c30 to dd3e2f0 Compare September 26, 2024 12:20
@TuningYourCode
Copy link
Contributor Author

This PR might be interpreted as breaking change as it might lead to issues if somebody was setting alias to another value than provider_id. Anyway it should be a pretty rare condition as provider_id needs to be an exact value matching a keycloak required action "identifier".

Also the code example in the keycloak_required_action provider was setting alias and provider_id to the same name.

There might be two options to solve the underlying issue:

  1. Use provider_id also for alias in all REST API calls (this PR)
  2. Map API field alias to some resource attribut not being part of the meta parameters of puppet (also breaking change)

@treydock treydock merged commit 0adda7f into treydock:master Oct 19, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flow & required action resources issue with multiple realms
2 participants