Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BackendValues in backend-comparison after removal of jit suffix #2756

Merged
merged 2 commits into from
Jan 30, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions backend-comparison/src/burnbenchapp/base.rs
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,13 @@ enum BackendValues {
CandleCuda,
#[strum(to_string = "candle-metal")]
CandleMetal,
#[strum(to_string = "cuda")]
Cuda,
#[strum(to_string = "cuda-fusion")]
CudaFusion,
#[cfg(target_os = "linux")]
#[strum(to_string = "hip")]
Hip,
#[strum(to_string = "ndarray")]
Ndarray,
#[strum(to_string = "ndarray-blas-accelerate")]
Expand All @@ -82,13 +89,6 @@ enum BackendValues {
WgpuSpirv,
#[strum(to_string = "wgpu-spirv-fusion")]
WgpuSpirvFusion,
#[strum(to_string = "cuda-jit")]
CudaJit,
#[strum(to_string = "cuda-jit-fusion")]
CudaJitFusion,
#[cfg(target_os = "linux")]
#[strum(to_string = "hip-jit")]
HipJit,
}

#[derive(Debug, Clone, PartialEq, Eq, ValueEnum, Display, EnumIter)]
Expand Down
4 changes: 2 additions & 2 deletions crates/burn-remote/src/server/session.rs
Original file line number Diff line number Diff line change
Expand Up @@ -101,12 +101,12 @@ impl<B: ReprBackend> SessionManager<B> {

impl<B: ReprBackend> Session<B> {
fn new(runner: Runner<B>) -> Self {
let (sender, reveiver) = std::sync::mpsc::sync_channel(1);
let (sender, receiver) = std::sync::mpsc::sync_channel(1);
Self {
runner,
streams: Default::default(),
sender,
receiver: Some(reveiver),
receiver: Some(receiver),
}
}

Expand Down
4 changes: 2 additions & 2 deletions crates/burn-tensor/src/tensor/backend/conversion.rs
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ mod tests {
}

#[test]
fn should_build_indices_2d_complexe() {
fn should_build_indices_2d_complex() {
let shape = Shape::new([2, 3]);

let indices = build_indices(&shape, Order::Left);
Expand All @@ -206,7 +206,7 @@ mod tests {
}

#[test]
fn should_build_indices_3d_complexe() {
fn should_build_indices_3d_complex() {
let shape = Shape::new([2, 5, 3]);

let indices = build_indices(&shape, Order::Left);
Expand Down
2 changes: 1 addition & 1 deletion examples/wgan/src/model.rs
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ impl<B: Backend> Discriminator<B> {
}
}

// Use model config to construct a generative and adverserial model
// Use model config to construct a generative and adversarial model
#[derive(Config, Debug)]
pub struct ModelConfig {
/// Dimensionality of the latent space
Expand Down