Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BackendValues in backend-comparison after removal of jit suffix #2756

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

syl20bnr
Copy link
Member

This PR also sorts the variants alphabetically like in the Cargo.toml file.

@syl20bnr syl20bnr requested a review from laggui January 30, 2025 15:59
Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, makes more sense to match the new backend flags.

The audit CI failure is due to polars 0.44.2, looks like they just released 0.46.0 a couple days ago that fixed the dependency causing this issue.

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.57%. Comparing base (04c5e74) to head (b03eebe).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/burn-remote/src/server/session.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2756   +/-   ##
=======================================
  Coverage   83.57%   83.57%           
=======================================
  Files         824      824           
  Lines      108453   108453           
=======================================
  Hits        90639    90639           
  Misses      17814    17814           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syl20bnr syl20bnr force-pushed the fix/backend-comparison-values branch from acee9e3 to b03eebe Compare January 30, 2025 17:08
@syl20bnr syl20bnr merged commit 6d8dd69 into main Jan 30, 2025
11 checks passed
@syl20bnr syl20bnr deleted the fix/backend-comparison-values branch January 30, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants