Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new FromData operation description #2735

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Add new FromData operation description #2735

merged 2 commits into from
Jan 24, 2025

Conversation

laggui
Copy link
Member

@laggui laggui commented Jan 22, 2025

Checklist

  • Confirmed that run-checks all script has been executed.

Related Issues/PRs

Fixes #2719

Changes

  • Added a new operation description for FromData, similar to other tensor creation ops (zeros, random, etc.)
  • Refactored fusion to use the FromData description (fixes linked issue, since an operation is registered the handles are correctly freed)
  • Fixed empty tensor op in fusion in the process (same issue as from data)

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 98.94180% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.56%. Comparing base (b33bd24) to head (99b5fbe).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
crates/burn-tensor/src/repr/operation.rs 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2735      +/-   ##
==========================================
- Coverage   83.59%   83.56%   -0.04%     
==========================================
  Files         819      824       +5     
  Lines      106600   108377    +1777     
==========================================
+ Hits        89113    90564    +1451     
- Misses      17487    17813     +326     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laggui laggui merged commit f978e7b into main Jan 24, 2025
11 checks passed
@laggui laggui deleted the fix/fusion-data branch January 24, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak
2 participants