Add Azure Key example and fix ECDSA OID check #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an example of using this library with a private key hosted in Azure Key Vault. This also includes a fix for loading an ephemeral ECDSA key from the .NET object by properly checking the curve OID value.
|
@tmds let me know if you want to split out the OID bugfix into a separate PR so your review on the Azure bits don't hold up your next release. |
tmds
reviewed
Sep 16, 2024
|
Great example, @jborean93! I've added some minor suggestions. |
tmds
reviewed
Sep 16, 2024
|
Thanks @jborean93! |
|
Thanks for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an example of using this library with a private key hosted in Azure Key Vault. This also includes a fix for loading an ephemeral ECDSA key from the .NET object by properly checking the curve OID value.