Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support [email protected]. #215

Merged
merged 5 commits into from
Aug 27, 2024
Merged

Support [email protected]. #215

merged 5 commits into from
Aug 27, 2024

Conversation

tmds
Copy link
Owner

@tmds tmds commented Aug 24, 2024

Fixes #214.

@jborean93 fyi

@tmds
Copy link
Owner Author

tmds commented Aug 24, 2024

I currently put [email protected] first in SupportedEncryptionAlgorithms so all (SshClientSettings-based) tests are now running with this algorithm.

I will add new tests to this PR which test the ciphers separately.

Copy link
Contributor

@jborean93 jborean93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really talk about the encryption code as I don't really understand chacha20poly1305 but the rest seems ok to me.

src/Tmds.Ssh/SshClientSettings.Defaults.cs Show resolved Hide resolved
src/Tmds.Ssh/SshClientSettings.Defaults.cs Outdated Show resolved Hide resolved
@tmds
Copy link
Owner Author

tmds commented Aug 26, 2024

@jborean93, thanks for taking a look!

@tmds tmds merged commit 6b467f8 into main Aug 27, 2024
2 checks passed
@tmds tmds deleted the chacha_poly branch September 16, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cipher: [email protected]
2 participants