Add support for ed25519 private keys #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for using ed25519 private key in user authentication. As .NET does not support ED25519 in the BCL it uses BouncyCastle.Cryptography as a dependency for the key signing tasks.
jborean93
commented
Aug 17, 2024
src/Tmds.Ssh/Ed25519PrivateKey.cs
Outdated
|
|
||
| // Contains the private and public key as one block of bytes from the | ||
| // serialized OpenSSH key data. | ||
| private readonly byte[] _keyData; |
There was a problem hiding this comment.
I used a single byte[] as that's how it is encoded in the raw OpenSSH key and the BouncyCastle API accepts an offset for the private and public key. Happy to just split that out in the parser and store it as 2 separate arrays if you prefer that.
There was a problem hiding this comment.
Yes, please split into separate arrays for the private and public key.
tmds
reviewed
Aug 18, 2024
src/Tmds.Ssh/Ed25519PrivateKey.cs
Outdated
|
|
||
| sealed class Ed25519PrivateKey : PrivateKey | ||
| { | ||
| private const int _privateKeySize = 32; |
There was a problem hiding this comment.
nit: for a const, the convention is PrivateKeySize.
There was a problem hiding this comment.
Thanks I'll remember that for next time. Now that the array is already split in the parser it's no longer needed.
|
Thanks for implementing this @jborean93! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for using ed25519 private key in user authentication. As .NET does not support ED25519 in the BCL it uses
BouncyCastle.Cryptography as a dependency for the key signing tasks.
Fixes #204