Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade ng-mocks to 14.12.1 #34

Merged
merged 4 commits into from
Feb 13, 2024
Merged

chore: upgrade ng-mocks to 14.12.1 #34

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
749ba7c
chore: upgrade `ng-mocks` to 14.12.1
michael-small Feb 11, 2024
94fe04f
chore: remove ng-mocks
michael-small Feb 13, 2024
300dcbd
chore: move @testing-library packages to devDependencies
michael-small Feb 13, 2024
51855b2
chore: update `package-lock.json` after moving and removing packages
michael-small Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
105 changes: 53 additions & 52 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"@angular/router": "17.0.2",
"@testing-library/angular": "14.4.0",
"@testing-library/user-event": "14.5.1",
"ng-mocks": "14.11.0",
"ng-mocks": "14.12.1",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this brings to my attention that we need to cleanup the dependencies 😅

@testing-library packages needs to move to devDependencies, ng-mocks isn't used and can thus be removed.
Do you want to update the PR with this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do that after work. It is 11:17 AM in my timezone so you will probably be sleeping by then. Otherwise I wouldn't mind if you want to do that now outside of the PR and close this.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no rush with it.
Please take your time 🙂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved two @testing-library packages to devDependencies, removed ng-mocks, and updated the package-lock.json.

"rxjs": "7.8.1",
"tslib": "^2.3.0",
"zone.js": "0.14.2"
Expand Down
Loading